Changeset 268630 in webkit

Timestamp:

Oct 16, 2020 9:08:43 PM (4 years ago)

Author:

Devin Rousso

Message:

Web Inspector: REGRESSION(r266885): LoggingChannel.js:31:23: CONSOLE ASSERT ERROR
​https://bugs.webkit.org/show_bug.cgi?id=217864

Reviewed by Timothy Hatcher.

r266885 changed Console.getLoggingChannels to return any Console.ChannelSource that
existed, rather than a hardcoded list. Remove the similarly hardcoded list in the frontend.

• UserInterface/Models/LoggingChannel.js:

(WI.LoggingChannel):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Models/LoggingChannel.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2020-10-16  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: REGRESSION(r266885): LoggingChannel.js:31:23: CONSOLE ASSERT ERROR
+        https://bugs.webkit.org/show_bug.cgi?id=217864
+
+        Reviewed by Timothy Hatcher.
+
+        r266885 changed `Console.getLoggingChannels` to return any `Console.ChannelSource` that
+        existed, rather than a hardcoded list. Remove the similarly hardcoded list in the frontend.
+
+        * UserInterface/Models/LoggingChannel.js:
+        (WI.LoggingChannel):
+
 2020-10-16  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Models/LoggingChannel.js

@@ -29 +29 @@
     {
         console.assert(typeof source === "string");
-        console.assert(source === WI.ConsoleMessage.MessageSource.Media || source === WI.ConsoleMessage.MessageSource.WebRTC || source === WI.ConsoleMessage.MessageSource.MediaSource);
+        console.assert(Object.values(WI.ConsoleMessage.MessageSource).includes(source), source);
 
         console.assert(typeof level === "string");
-        console.assert(Object.values(WI.LoggingChannel.Level).includes(level));
+        console.assert(Object.values(WI.LoggingChannel.Level).includes(level), level);
 
         this._source = source;