Changeset 268674 in webkit

Timestamp:

Oct 19, 2020, 11:17:18 AM (5 years ago)

Author:

aakash_jain@apple.com

Message:

[build.webkit.org] Use feature flag to support Buildbot 2 code
​https://bugs.webkit.org/show_bug.cgi?id=217834

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/build.webkit.org-config/loadConfig.py:

(loadBuilderConfig):

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/loadConfig.py (modified) (5 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/loadConfig.py ¶

@@ -21 +21 @@
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-from buildbot.buildslave import BuildSlave
+import os
+USE_BUILDBOT_VERSION2 = os.getenv('USE_BUILDBOT_VERSION2') is not None
+
+if USE_BUILDBOT_VERSION2:
+    from buildbot.worker import Worker
+else:
+    from buildbot.buildslave import BuildSlave
 from buildbot.scheduler import AnyBranchScheduler, Triggerable, Nightly
 from buildbot.schedulers.forcesched import FixedParameter, ForceScheduler, StringParameter, BooleanParameter
@@ -59 +65 @@
 
     config = json.load(open('config.json'))
-    c['slaves'] = [BuildSlave(worker['name'], passwords.get(worker['name'], 'password'), max_builds=1) for worker in config['workers']]
+    if USE_BUILDBOT_VERSION2:
+        c['workers'] = [Worker(worker['name'], passwords.get(worker['name'], 'password'), max_builds=1) for worker in config['workers']]
+    else:
+        c['slaves'] = [BuildSlave(worker['name'], passwords.get(worker['name'], 'password'), max_builds=1) for worker in config['workers']]
 
     c['schedulers'] = []
@@ -100 +109 @@
                 break
 
-        builder['slavenames'] = builder.pop('workernames')  # Workaround for old buildbot to allow using workernames in config.json instead of slavenames
+        if not USE_BUILDBOT_VERSION2:
+            builder['slavenames'] = builder.pop('workernames')
         platform = builder['platform']
 
@@ -119 +129 @@
             raise Exception('Builder name "{}" is not a valid buildbot identifier.'.format(builder_name))
         for step in builder["factory"].steps:
-            step_name = step[0].name
+            if USE_BUILDBOT_VERSION2:
+                step_name = step.buildStep().name
+            else:
+                step_name = step[0].name
             if len(step_name) > STEP_NAME_LENGTH_LIMIT:
                 raise Exception('step name "{}" is longer than maximum allowed by Buildbot ({} characters).'.format(step_name, STEP_NAME_LENGTH_LIMIT))
@@ -126 +139 @@
 
         if platform.startswith('mac'):
-            builder["category"] = 'AppleMac'
+            category = 'AppleMac'
         elif platform.startswith('ios'):
-            builder['category'] = 'iOS'
+            category = 'iOS'
         elif platform == 'win':
-            builder["category"] = 'AppleWin'
+            category = 'AppleWin'
         elif platform.startswith('gtk'):
-            builder["category"] = 'GTK'
+            category = 'GTK'
         elif platform.startswith('wpe'):
-            builder["category"] = 'WPE'
+            category = 'WPE'
         elif platform == 'wincairo':
-            builder["category"] = 'WinCairo'
+            category = 'WinCairo'
         elif platform.startswith('playstation'):
-            builder["category"] = 'PlayStation'
+            category = 'PlayStation'
         else:
-            builder["category"] = 'misc'
+            category = 'misc'
 
-        if (builder['category'] in ('AppleMac', 'AppleWin', 'iOS')) and factoryName != 'BuildFactory':
+        if (category in ('AppleMac', 'AppleWin', 'iOS')) and factoryName != 'BuildFactory':
             builder['nextBuild'] = pickLatestBuild
 
+        if not USE_BUILDBOT_VERSION2:
+            builder['category'] = category
         c['builders'].append(builder)
 

trunk/Tools/ChangeLog ¶

@@ +1 @@
+2020-10-19  Aakash Jain  <aakash_jain@apple.com>
+
+        [build.webkit.org] Use feature flag to support Buildbot 2 code
+        https://bugs.webkit.org/show_bug.cgi?id=217834
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
+        (loadBuilderConfig):
+
 2020-10-19  Jonathan Bedard  <jbedard@apple.com>