Changeset 269667 in webkit

Timestamp:

Nov 10, 2020 5:07:50 PM (3 years ago)

Author:

commit-queue@webkit.org

Message:

stress/intl-datetimeformat-formatrange.js and stress/intl-datetimeformat-formatrange-relevant-extensions.js fail with ICU 65.1
​https://bugs.webkit.org/show_bug.cgi?id=218763

Patch by Michael Catanzaro <Michael Catanzaro> on 2020-11-10
Reviewed by Yusuke Suzuki.

Yesterday Red Hat upgraded its internal CI to Fedora 32 (ICU 65.1), causing
stress/intl-datetimeformat-formatrange-relevant-extensions.js and
stress/intl-datetimeformat-formatrange.js to begin failing. The problem is that the space
characters used in the range format changed at some point. The current version of the test
expects normal ASCII space characters for ICU 67 and newer, and special spaces for older
versions of ICU.

The test passes for me locally on Fedora 33 (ICU 67.1), so perhaps we just need to use the
new codepath for ICU 65 and 66 as well.

• stress/intl-datetimeformat-formatrange-relevant-extensions.js:
• stress/intl-datetimeformat-formatrange.js:

(test):

Location:

trunk/JSTests

Files:

• ChangeLog (modified) (1 diff)
• stress/intl-datetimeformat-formatrange-relevant-extensions.js (modified) (1 diff)
• stress/intl-datetimeformat-formatrange.js (modified) (1 diff)

trunk/JSTests/ChangeLog

@@ +1 @@
+2020-11-10  Michael Catanzaro  <mcatanzaro@gnome.org>
+
+        stress/intl-datetimeformat-formatrange.js and stress/intl-datetimeformat-formatrange-relevant-extensions.js fail with ICU 65.1
+        https://bugs.webkit.org/show_bug.cgi?id=218763
+
+        Reviewed by Yusuke Suzuki.
+
+        Yesterday Red Hat upgraded its internal CI to Fedora 32 (ICU 65.1), causing
+        stress/intl-datetimeformat-formatrange-relevant-extensions.js and
+        stress/intl-datetimeformat-formatrange.js to begin failing. The problem is that the space
+        characters used in the range format changed at some point. The current version of the test
+        expects normal ASCII space characters for ICU 67 and newer, and special spaces for older
+        versions of ICU.
+
+        The test passes for me locally on Fedora 33 (ICU 67.1), so perhaps we just need to use the
+        new codepath for ICU 65 and 66 as well.
+
+        * stress/intl-datetimeformat-formatrange-relevant-extensions.js:
+        * stress/intl-datetimeformat-formatrange.js:
+        (test):
+
 2020-11-09  Keith Miller  <keith_miller@apple.com>
 

trunk/JSTests/stress/intl-datetimeformat-formatrange-relevant-extensions.js

@@ -20 +20 @@
 
 function test() {
-    let range = " – "; // This is not usual space unfortuantely in ICU 66.
-    if ($vm.icuVersion() > 66)
+    let range = " – "; // This is not usual space unfortuantely in older ICU versions.
+    if ($vm.icuVersion() >= 65)
         range = " – ";
 

trunk/JSTests/stress/intl-datetimeformat-formatrange.js

@@ -34 +34 @@
 
 function test() {
-    let range = " – "; // This is not usual space unfortuantely in ICU 66.
-    if ($vm.icuVersion() > 66)
+    let range = " – "; // This is not usual space unfortuantely in older ICU versions.
+    if ($vm.icuVersion() >= 65)
         range = " – ";