Changeset 269734 in webkit

Timestamp:

Nov 12, 2020 9:37:25 AM (3 years ago)

Author:

Alan Bujtas

Message:

[LFC][Integration] vertical-align: super and sub values are not supported yet.
​https://bugs.webkit.org/show_bug.cgi?id=218851

Reviewed by Antti Koivisto.

• layout/integration/LayoutIntegrationCoverage.cpp:

(WebCore::LayoutIntegration::canUseForChild):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• layout/integration/LayoutIntegrationCoverage.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-11-12  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC][Integration] vertical-align: super and sub values are not supported yet.
+        https://bugs.webkit.org/show_bug.cgi?id=218851
+
+        Reviewed by Antti Koivisto.
+
+        * layout/integration/LayoutIntegrationCoverage.cpp:
+        (WebCore::LayoutIntegration::canUseForChild):
+
 2020-11-12  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp

@@ -588 +588 @@
             SET_REASON_AND_RETURN_IF_NEEDED(FlowHasNonSupportedChild, reasons, includeReasons);
 
+        if (style.verticalAlign() == VerticalAlign::Sub || style.verticalAlign() == VerticalAlign::Super)
+            SET_REASON_AND_RETURN_IF_NEEDED(FlowHasNonSupportedChild, reasons, includeReasons);
+
         if (is<RenderImage>(replaced)) {
             auto& image = downcast<RenderImage>(replaced);
@@ -612 +615 @@
 
         auto& style = block.style();
-        if (style.verticalAlign() != VerticalAlign::Baseline)
+        if (style.verticalAlign() == VerticalAlign::Sub || style.verticalAlign() == VerticalAlign::Super)
             SET_REASON_AND_RETURN_IF_NEEDED(FlowHasNonSupportedChild, reasons, includeReasons);
         if (style.width().isPercent() || style.height().isPercent())