Changeset 269859 in webkit

Timestamp:

Nov 16, 2020 10:12:17 AM (3 years ago)

Author:

Andres Gonzalez

Message:

Add logging of AXCoreObject outerHTML to AXLogger.
​https://bugs.webkit.org/show_bug.cgi?id=218958

Reviewed by Chris Fleizach.

No change in functionality, debugging code.

• accessibility/AXLogger.cpp:

(WebCore::operator<<):

• Added logging of the outerHTML of the corresponding Element for AXCoreObjects.
• Added logging of the platform wrapper address for AXCoreObjects.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• accessibility/AXLogger.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-11-16  Andres Gonzalez  <andresg_22@apple.com>
+
+        Add logging of AXCoreObject outerHTML to AXLogger.
+        https://bugs.webkit.org/show_bug.cgi?id=218958
+
+        Reviewed by Chris Fleizach.
+
+        No change in functionality, debugging code.
+
+        * accessibility/AXLogger.cpp:
+        (WebCore::operator<<):
+        - Added logging of the outerHTML of the corresponding Element for AXCoreObjects.
+        - Added logging of the platform wrapper address for AXCoreObjects.
+
 2020-11-16  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/accessibility/AXLogger.cpp

@@ -265 +265 @@
     stream << "objectID " << object.objectID();
     stream.dumpProperty("identifierAttribute", object.identifierAttribute());
-    stream.dumpProperty("roleValue", object.roleValue());
+    auto role = object.roleValue();
+    stream.dumpProperty("roleValue", role);
+
+    auto* objectWithInterestingHTML = role == AccessibilityRole::Button ? // Add here other roles of interest.
+        &object : nullptr;
+    auto* parent = object.parentObject();
+    if (role == AccessibilityRole::StaticText && parent)
+        objectWithInterestingHTML = parent;
+    if (objectWithInterestingHTML) {
+        if (auto* element = objectWithInterestingHTML->element())
+            stream.dumpProperty("outerHTML", element->outerHTML());
+    }
+
     stream.dumpProperty("address", &object);
-
-    auto* parent = object.parentObject();
+    stream.dumpProperty("wrapper", object.wrapper());
+
     stream.dumpProperty("parentObject", parent ? parent->objectID() : 0);
 #if PLATFORM(COCOA)