Changeset 269908 in webkit

Timestamp:

Nov 17, 2020 9:28:09 AM (3 years ago)

Author:

Chris Dumez

Message:

[iOS] Stop leaking an XPC transaction in our XPC services
​https://bugs.webkit.org/show_bug.cgi?id=219036

Reviewed by Geoffrey Garen.

Stop leaking an XPC transaction in our XPC services on iOS. We were doing this to control the lifetime of our child services
ourselves. However, this is not needed on iOS because the UIProcess takes RunningBoard process assertions on behalf of its
child processes.

I have verified that our child processes do not exit/jetsam early. I have verified that our child processes are in the
correct jetsam band (IDLE/0 when background and FG/10 when foreground). I have also verified that the main thread of these
processes runs at UserInitiated QoS before and after this change.

• Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h:

(WebKit::XPCServiceInitializer):

• Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm:

(WebKit::XPCServiceExit):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h (modified) (1 diff)
• Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-11-17  Chris Dumez  <cdumez@apple.com>
+
+        [iOS] Stop leaking an XPC transaction in our XPC services
+        https://bugs.webkit.org/show_bug.cgi?id=219036
+
+        Reviewed by Geoffrey Garen.
+
+        Stop leaking an XPC transaction in our XPC services on iOS. We were doing this to control the lifetime of our child services
+        ourselves. However, this is not needed on iOS because the UIProcess takes RunningBoard process assertions on behalf of its
+        child processes.
+
+        I have verified that our child processes do not exit/jetsam early. I have verified that our child processes are in the
+        correct jetsam band (IDLE/0 when background and FG/10 when foreground). I have also verified that the main thread of these
+        processes runs at UserInitiated QoS before and after this change.
+
+        * Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h:
+        (WebKit::XPCServiceInitializer):
+        * Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm:
+        (WebKit::XPCServiceExit):
+
 2020-11-17  Peng Liu  <peng.liu6@apple.com>
 

trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h

@@ -92 +92 @@
 
     // We don't want XPC to be in charge of whether the process should be terminated or not,
-    // so ensure that we have an outstanding transaction here.
+    // so ensure that we have an outstanding transaction here. This is not needed on iOS because
+    // the UIProcess takes process assertions on behalf of its child processes.
+#if PLATFORM(MAC)
 ALLOW_DEPRECATED_DECLARATIONS_BEGIN
     xpc_transaction_begin();
 ALLOW_DEPRECATED_DECLARATIONS_END
+#endif
 
     InitializeWebKit2();

trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm

@@ -145 +145 @@
     // Make sure to destroy the priority boost message to avoid leaking a transaction.
     priorityBoostMessage = nullptr;
+
     // Balances the xpc_transaction_begin() in XPCServiceInitializer.
+#if PLATFORM(MAC)
 ALLOW_DEPRECATED_DECLARATIONS_BEGIN
     xpc_transaction_end();
 ALLOW_DEPRECATED_DECLARATIONS_END
+#endif
+
     xpc_transaction_exit_clean();
 }