Changeset 269993 in webkit

Timestamp:

Nov 18, 2020 3:01:01 PM (3 years ago)

Author:

Chris Dumez

Message:

Drop redundant code that tries to bump the QoS of the WebContent main thread of UserInteractive when handling a sync IPC
​https://bugs.webkit.org/show_bug.cgi?id=219110

Reviewed by Alex Christensen.

Drop redundant code that tries to bump the QoS of the WebContent main thread of UserInteractive when
handling a sync IPC. Nowadays, we always run the main thread of the WebContent at UserInteractive QoS
(see WTF::Thread::setCurrentThreadIsUserInteractive() call in WebProcess::initializeWebProcess()) so
there is no need to boost the QoS during a sync IPC.

• Platform/IPC/Connection.cpp:

(IPC::Connection::processIncomingMessage):

• Platform/IPC/Connection.h:

(IPC::Connection::setShouldBoostMainThreadOnSyncMessage): Deleted.

• Platform/IPC/Decoder.h:

(IPC::Decoder::setQOSClassOverride): Deleted.

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeConnection):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Platform/IPC/Connection.cpp (modified) (1 diff)
• Platform/IPC/Connection.h (modified) (2 diffs)
• Platform/IPC/Decoder.cpp (modified) (1 diff)
• Platform/IPC/Decoder.h (modified) (2 diffs)
• WebProcess/WebProcess.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-11-18  Chris Dumez  <cdumez@apple.com>
+
+        Drop redundant code that tries to bump the QoS of the WebContent main thread of UserInteractive when handling a sync IPC
+        https://bugs.webkit.org/show_bug.cgi?id=219110
+
+        Reviewed by Alex Christensen.
+
+        Drop redundant code that tries to bump the QoS of the WebContent main thread of UserInteractive when
+        handling a sync IPC. Nowadays, we always run the main thread of the WebContent at UserInteractive QoS
+        (see WTF::Thread::setCurrentThreadIsUserInteractive() call in WebProcess::initializeWebProcess()) so
+        there is no need to boost the QoS during a sync IPC.
+
+        * Platform/IPC/Connection.cpp:
+        (IPC::Connection::processIncomingMessage):
+        * Platform/IPC/Connection.h:
+        (IPC::Connection::setShouldBoostMainThreadOnSyncMessage): Deleted.
+        * Platform/IPC/Decoder.h:
+        (IPC::Decoder::setQOSClassOverride): Deleted.
+        * WebProcess/WebProcess.cpp:
+        (WebKit::WebProcess::initializeConnection):
+
 2020-11-18  Darin Adler  <darin@apple.com>
 

trunk/Source/WebKit/Platform/IPC/Connection.cpp

@@ -749 +749 @@
         return;
 
-#if HAVE(QOS_CLASSES)
-    if (message->isSyncMessage() && m_shouldBoostMainThreadOnSyncMessage) {
-        pthread_override_t override = pthread_override_qos_class_start_np(m_mainThread, Thread::adjustedQOSClass(QOS_CLASS_USER_INTERACTIVE), 0);
-        message->setQOSClassOverride(override);
-    }
-#endif
-
     if (message->isSyncMessage()) {
         auto locker = holdLock(m_incomingSyncMessageCallbackMutex);

trunk/Source/WebKit/Platform/IPC/Connection.h

@@ -283 +283 @@
     bool isValid() const { return m_isValid; }
 
-#if HAVE(QOS_CLASSES)
-    void setShouldBoostMainThreadOnSyncMessage(bool b) { m_shouldBoostMainThreadOnSyncMessage = b; }
-#endif
-
     uint64_t installIncomingSyncMessageCallback(WTF::Function<void()>&&);
     void uninstallIncomingSyncMessageCallback(uint64_t);
@@ -436 +432 @@
 #if HAVE(QOS_CLASSES)
     pthread_t m_mainThread { 0 };
-    bool m_shouldBoostMainThreadOnSyncMessage { false };
 #endif
 

trunk/Source/WebKit/Platform/IPC/Decoder.cpp

@@ -95 +95 @@
 
     // FIXME: We need to dispose of the mach ports in cases of failure.
-
-#if HAVE(QOS_CLASSES)
-    if (m_qosClassOverride)
-        pthread_override_qos_class_end_np(m_qosClassOverride);
-#endif
 }
 

trunk/Source/WebKit/Platform/IPC/Decoder.h

@@ -68 +68 @@
 #endif
 
-#if HAVE(QOS_CLASSES)
-    void setQOSClassOverride(pthread_override_t override) { m_qosClassOverride = override; }
-#endif
-
     static std::unique_ptr<Decoder> unwrapForTesting(Decoder&);
 
@@ -209 +205 @@
     std::unique_ptr<ImportanceAssertion> m_importanceAssertion;
 #endif
-
-#if HAVE(QOS_CLASSES)
-    pthread_override_t m_qosClassOverride { nullptr };
-#endif
 };
 

trunk/Source/WebKit/WebProcess/WebProcess.cpp

@@ -313 +313 @@
 #endif
 
-#if HAVE(QOS_CLASSES)
-    connection->setShouldBoostMainThreadOnSyncMessage(true);
-#endif
-
     m_eventDispatcher->initializeConnection(connection);
 #if PLATFORM(IOS_FAMILY)