Changeset 270110 in webkit

Timestamp:

Nov 20, 2020 6:47:29 AM (3 years ago)

Author:

Antti Koivisto

Message:

[LFC][Integration] Take alignment offset into account when computing line iterator logicalLeft
​https://bugs.webkit.org/show_bug.cgi?id=219197

Reviewed by Zalan Bujtas.

This fixes editing/style/text-indent.html with LFC editing enabled.

• layout/integration/LayoutIntegrationLineIteratorModernPath.h:

(WebCore::LayoutIntegration::LineIteratorModernPath::logicalLeft const):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• layout/integration/LayoutIntegrationLineIteratorModernPath.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-11-20  Antti Koivisto  <antti@apple.com>
+
+        [LFC][Integration] Take alignment offset into account when computing line iterator logicalLeft
+        https://bugs.webkit.org/show_bug.cgi?id=219197
+
+        Reviewed by Zalan Bujtas.
+
+        This fixes editing/style/text-indent.html with LFC editing enabled.
+
+        * layout/integration/LayoutIntegrationLineIteratorModernPath.h:
+        (WebCore::LayoutIntegration::LineIteratorModernPath::logicalLeft const):
+
 2020-11-20  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/layout/integration/LayoutIntegrationLineIteratorModernPath.h

@@ -60 +60 @@
     LayoutUnit selectionBottom() const { return bottom(); }
 
-    float logicalLeft() const { return line().rect().x(); }
+    float logicalLeft() const { return line().rect().x() + line().horizontalAlignmentOffset(); }
     float logicalRight() const { return logicalLeft() + line().lineBoxWidth(); }
     float y() const { return lineBoxTop(); }