Changeset 270700 in webkit

Timestamp:

Dec 11, 2020 12:10:12 PM (3 years ago)

Author:

Tadeu Zagallo

Message:

REGRESSION (r270665): testapi failing on CLoop bot
​https://bugs.webkit.org/show_bug.cgi?id=219787

Reviewed by Mark Lam.

The API has to special case the empty JSValue as null.

• API/JSValueRef.cpp:

(JSValueGetType):
(JSValueIsNull):

Location:

trunk/Source/JavaScriptCore

Files:

• API/JSValueRef.cpp (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/Source/JavaScriptCore/API/JSValueRef.cpp

@@ -65 +65 @@
     if (jsValue.isUndefined())
         return kJSTypeUndefined;
-    if (jsValue.isNull())
+    if (!jsValue || jsValue.isNull())
         return kJSTypeNull;
     if (jsValue.isBoolean())
@@ -106 +106 @@
     return toJS(globalObject, value).isNull();
 #else
-    return toJS(value).isNull();
+    return !value || toJS(value).isNull();
 #endif
 }

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-12-11  Tadeu Zagallo  <tzagallo@apple.com>
+
+        REGRESSION (r270665): testapi failing on CLoop bot
+        https://bugs.webkit.org/show_bug.cgi?id=219787
+
+        Reviewed by Mark Lam.
+
+        The API has to special case the empty JSValue as null.
+
+        * API/JSValueRef.cpp:
+        (JSValueGetType):
+        (JSValueIsNull):
+
 2020-12-11  Don Olmstead  <don.olmstead@sony.com>