Changeset 271753 in webkit

Timestamp:

Jan 22, 2021 11:53:55 AM (3 years ago)

Author:

jiewen_tan@apple.com

Message:

[WebAuthn] Should only check default browsers for the Modern WebAuthn
​https://bugs.webkit.org/show_bug.cgi?id=220840
<rdar://problem/73375937>

Reviewed by Brent Fulgham.

• WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp:

(WebKit::WebAuthenticatorCoordinator::makeCredential):
(WebKit::WebAuthenticatorCoordinator::getAssertion):
(WebKit::WebAuthenticatorCoordinator::isUserVerifyingPlatformAuthenticatorAvailable):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp (modified) (3 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-01-22  Jiewen Tan  <jiewen_tan@apple.com>
+
+        [WebAuthn] Should only check default browsers for the Modern WebAuthn
+        https://bugs.webkit.org/show_bug.cgi?id=220840
+        <rdar://problem/73375937>
+
+        Reviewed by Brent Fulgham.
+
+        * WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp:
+        (WebKit::WebAuthenticatorCoordinator::makeCredential):
+        (WebKit::WebAuthenticatorCoordinator::getAssertion):
+        (WebKit::WebAuthenticatorCoordinator::isUserVerifyingPlatformAuthenticatorAvailable):
+
 2021-01-21  Peng Liu  <peng.liu6@apple.com>
 

trunk/Source/WebKit/WebProcess/WebAuthentication/WebAuthenticatorCoordinator.cpp

@@ -73 +73 @@
 
     if (!RuntimeEnabledFeatures::sharedFeatures().webAuthenticationModernEnabled()) {
-        if (!isWebBrowser())
-            return;
-
         m_webPage.sendWithAsyncReply(Messages::WebAuthenticatorCoordinatorProxy::MakeCredential(webFrame->frameID(), webFrame->info(), hash, options, processingUserGesture), WTFMove(handler));
         return;
     }
 
+    if (!isWebBrowser())
+        return;
     WebProcess::singleton().ensureWebAuthnProcessConnection().connection().sendWithAsyncReply(Messages::WebAuthnConnectionToWebProcess::MakeCredential(hash, options, processingUserGesture), WTFMove(handler));
 }
@@ -94 +93 @@
 
     if (!RuntimeEnabledFeatures::sharedFeatures().webAuthenticationModernEnabled()) {
-        if (!isWebBrowser())
-            return;
-
         m_webPage.sendWithAsyncReply(Messages::WebAuthenticatorCoordinatorProxy::GetAssertion(webFrame->frameID(), webFrame->info(), hash, options, processingUserGesture), WTFMove(handler));
         return;
     }
 
+    if (!isWebBrowser())
+        return;
     WebProcess::singleton().ensureWebAuthnProcessConnection().connection().sendWithAsyncReply(Messages::WebAuthnConnectionToWebProcess::GetAssertion(hash, options, processingUserGesture), WTFMove(handler));
 }
@@ -107 +105 @@
 {
     if (!RuntimeEnabledFeatures::sharedFeatures().webAuthenticationModernEnabled()) {
-        if (!isWebBrowser())
-            return;
-
         m_webPage.sendWithAsyncReply(Messages::WebAuthenticatorCoordinatorProxy::IsUserVerifyingPlatformAuthenticatorAvailable(), WTFMove(handler));
         return;
     }
 
+    if (!isWebBrowser())
+        return;
     WebProcess::singleton().ensureWebAuthnProcessConnection().connection().sendWithAsyncReply(Messages::WebAuthnConnectionToWebProcess::IsUserVerifyingPlatformAuthenticatorAvailable(), WTFMove(handler));
 }