Changeset 271767 in webkit

Timestamp:

Jan 22, 2021 4:23:06 PM (3 years ago)

Author:

keith_miller@apple.com

Message:

Obj-C API should do correct type checks when using a 32-bit address space
​https://bugs.webkit.org/show_bug.cgi?id=220880
<rdar://72370334>

Reviewed by Tadeu Zagallo.

• API/JSValue.mm:

(-[JSValue isNull]):
(-[JSValue isBoolean]):
(-[JSValue isNumber]):
(-[JSValue isString]):

Location:

trunk/Source/JavaScriptCore

Files:

• API/JSValue.mm (modified) (4 diffs)
• ChangeLog (modified) (1 diff)

trunk/Source/JavaScriptCore/API/JSValue.mm

@@ -409 +409 @@
 {
 #if !CPU(ADDRESS64)
-    return JSValueIsUndefined([_context JSGlobalContextRef], m_value);
+    return JSValueIsNull([_context JSGlobalContextRef], m_value);
 #else
     return toJS(m_value).isNull();
@@ -418 +418 @@
 {
 #if !CPU(ADDRESS64)
-    return JSValueIsUndefined([_context JSGlobalContextRef], m_value);
+    return JSValueIsBoolean([_context JSGlobalContextRef], m_value);
 #else
     return toJS(m_value).isBoolean();
@@ -427 +427 @@
 {
 #if !CPU(ADDRESS64)
-    return JSValueIsUndefined([_context JSGlobalContextRef], m_value);
+    return JSValueIsNumber([_context JSGlobalContextRef], m_value);
 #else
     return toJS(m_value).isNumber();
@@ -436 +436 @@
 {
 #if !CPU(ADDRESS64)
-    return JSValueIsUndefined([_context JSGlobalContextRef], m_value);
+    return JSValueIsString([_context JSGlobalContextRef], m_value);
 #else
     return toJS(m_value).isString();

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2021-01-22  Keith Miller  <keith_miller@apple.com>
+
+        Obj-C API should do correct type checks when using a 32-bit address space
+        https://bugs.webkit.org/show_bug.cgi?id=220880
+        <rdar://72370334>
+
+        Reviewed by Tadeu Zagallo.
+
+        * API/JSValue.mm:
+        (-[JSValue isNull]):
+        (-[JSValue isBoolean]):
+        (-[JSValue isNumber]):
+        (-[JSValue isString]):
+
 2021-01-22  Yusuke Suzuki  <ysuzuki@apple.com>