Changeset 272363 in webkit

Timestamp:

Feb 4, 2021 1:11:28 AM (3 years ago)

Author:

commit-queue@webkit.org

Message:

Make shouldComputeLogicalWidthFromAspectRatioAndInsets writing mode aware
​https://bugs.webkit.org/show_bug.cgi?id=221328

Patch by Rob Buis <​rbuis@igalia.com> on 2021-02-04
Reviewed by Manuel Rego Casasnovas.

Source/WebCore:

Commit r271061 added support for aspect-ratio on positioned elements, taking into account
insets, but it failed to take writing-mode into account when checking insets. This change fixes
that by asking logical values.

• rendering/RenderBox.cpp:

(WebCore::RenderBox::shouldComputeLogicalWidthFromAspectRatioAndInsets const):

LayoutTests:

Enable some tests that pass now.

• TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderBox.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-02-04  Rob Buis  <rbuis@igalia.com>
+
+        Make shouldComputeLogicalWidthFromAspectRatioAndInsets writing mode aware
+        https://bugs.webkit.org/show_bug.cgi?id=221328
+
+        Reviewed by Manuel Rego Casasnovas.
+
+        Enable some tests that pass now.
+
+        * TestExpectations:
+
 2021-02-04  Miguel Gomez  <magomez@igalia.com>
 

trunk/LayoutTests/TestExpectations

@@ -4409 +4409 @@
 webkit.org/b/214462 imported/w3c/web-platform-tests/css/css-scoping/slotted-placeholder.html [ ImageOnlyFailure ]
 
-webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-004.html [ ImageOnlyFailure ]
 webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-012.html [ ImageOnlyFailure ]
 webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-013.html [ ImageOnlyFailure ]
 webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-014.html [ ImageOnlyFailure ]
-webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/abspos-015.html [ ImageOnlyFailure ]
 webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-004.html [ ImageOnlyFailure ]
 webkit.org/b/214463 imported/w3c/web-platform-tests/css/css-sizing/aspect-ratio/block-aspect-ratio-006.html [ ImageOnlyFailure ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-02-04  Rob Buis  <rbuis@igalia.com>
+
+        Make shouldComputeLogicalWidthFromAspectRatioAndInsets writing mode aware
+        https://bugs.webkit.org/show_bug.cgi?id=221328
+
+        Reviewed by Manuel Rego Casasnovas.
+
+        Commit r271061 added support for aspect-ratio on positioned elements, taking into account
+        insets, but it failed to take writing-mode into account when checking insets. This change fixes
+        that by asking logical values.
+
+        * rendering/RenderBox.cpp:
+        (WebCore::RenderBox::shouldComputeLogicalWidthFromAspectRatioAndInsets const):
+
 2021-02-04  Miguel Gomez  <magomez@igalia.com>
 

trunk/Source/WebCore/rendering/RenderBox.cpp

@@ -5101 +5101 @@
         return false;
     // FIXME: see if this can become a helper on RenderStyle.
-    if (style().width().isAuto() && style().height().isAuto() && !style().top().isAuto() && !style().bottom().isAuto() && (style().left().isAuto() || style().right().isAuto()))
+    if (style().width().isAuto() && style().height().isAuto() && !style().logicalTop().isAuto() && !style().logicalBottom().isAuto() && (style().logicalLeft().isAuto() || style().logicalRight().isAuto()))
         return true;
     return false;