Changeset 272491 in webkit

Timestamp:

Feb 8, 2021 8:14:32 AM (3 years ago)

Author:

commit-queue@webkit.org

Message:

Fix WebXRWebGLLayer m_isCompositionDisabled checks
​https://bugs.webkit.org/show_bug.cgi?id=221551

Patch by Imanol Fernandez <imanol> on 2021-02-08
Reviewed by Sergio Villar Senin.

Fix reversed m_isCompositionDisabled checks.

• Modules/webxr/WebXRWebGLLayer.cpp:

(WebCore::WebXRWebGLLayer::create):
(WebCore::WebXRWebGLLayer::WebXRWebGLLayer):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/webxr/WebXRWebGLLayer.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-02-08  Imanol Fernandez  <ifernandez@igalia.com>
+
+        Fix WebXRWebGLLayer m_isCompositionDisabled checks
+        https://bugs.webkit.org/show_bug.cgi?id=221551
+
+        Reviewed by Sergio Villar Senin.
+
+        Fix reversed m_isCompositionDisabled checks.
+
+        * Modules/webxr/WebXRWebGLLayer.cpp:
+        (WebCore::WebXRWebGLLayer::create):
+        (WebCore::WebXRWebGLLayer::WebXRWebGLLayer):
+
 2021-02-08  Andres Gonzalez  <andresg_22@apple.com>
 

trunk/Source/WebCore/Modules/webxr/WebXRWebGLLayer.cpp

@@ -75 +75 @@
             auto layer = adoptRef(*new WebXRWebGLLayer(WTFMove(session), WTFMove(context), init));
 
-            if (layer->m_isCompositionDisabled) {
+            if (!layer->m_isCompositionDisabled) {
                 // 9.4. Allocate and initialize resources compatible with session’s XR device, including GPU accessible memory buffers,
                 //      as required to support the compositing of layer.
@@ -110 +110 @@
 
     // 9. If layer’s composition disabled boolean is false:
-    if (m_isCompositionDisabled) {
+    if (!m_isCompositionDisabled) {
         //  1. Initialize layer’s antialias to layerInit’s antialias value.
         m_antialias = init.antialias;