Changeset 272913 in webkit

Timestamp:

Feb 16, 2021 10:04:41 AM (3 years ago)

Author:

youenn@apple.com

Message:

AVAudioSessionCaptureDeviceManager should disable its audio session in a background thread
​https://bugs.webkit.org/show_bug.cgi?id=221949
<rdar://problem/74315824>

Reviewed by Eric Carlson.

Manually tested.

• platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm:

(WebCore::AVAudioSessionCaptureDeviceManager::disableAllDevicesQuery):
Hop to a background thread before disabling the audio session.
Abort if audio session is no longer marked as unneeded.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-02-16  Youenn Fablet  <youenn@apple.com>
+
+        AVAudioSessionCaptureDeviceManager should disable its audio session in a background thread
+        https://bugs.webkit.org/show_bug.cgi?id=221949
+        <rdar://problem/74315824>
+
+        Reviewed by Eric Carlson.
+
+        Manually tested.
+
+        * platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm:
+        (WebCore::AVAudioSessionCaptureDeviceManager::disableAllDevicesQuery):
+        Hop to a background thread before disabling the audio session.
+        Abort if audio session is no longer marked as unneeded.
+
 2021-02-16  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm

@@ -254 +254 @@
 
     if (m_audioSessionState == AudioSessionState::Active) {
-        NSError *error = nil;
-        [m_audioSession setActive:NO withOptions:0 error:&error];
-        if (error)
-            RELEASE_LOG_ERROR(WebRTC, "Failed to disactivate audio session with error: %@.", error.localizedDescription);
+        dispatch_async(m_dispatchQueue, makeBlockPtr([this] {
+            if (m_audioSessionState != AudioSessionState::NotNeeded)
+                return;
+            NSError *error = nil;
+            [m_audioSession setActive:NO withOptions:0 error:&error];
+            if (error)
+                RELEASE_LOG_ERROR(WebRTC, "Failed to disactivate audio session with error: %@.", error.localizedDescription);
+        }).get());
     }