Changeset 273156 in webkit

Timestamp:

Feb 19, 2021 12:09:37 PM (3 years ago)

Author:

Fujii Hironori

Message:

A number of offscreencanvas tests are asserting isMainThread trying to access strictCSSParserContext
​https://bugs.webkit.org/show_bug.cgi?id=222156

Reviewed by Carlos Garcia Campos.

Source/WebCore:

strictCSSParserContext() can be used only in the main thread.
It can't be used in parseColorWorkerSafe().

• css/parser/CSSParser.cpp:

(WebCore::CSSParser::parseColorWorkerSafe): Use
CSSParserContext(HTMLStandardMode) instead of
strictCSSParserContext().

LayoutTests:

• platform/glib/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/glib/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/parser/CSSParser.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-02-19  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        A number of offscreencanvas tests are asserting isMainThread trying to access strictCSSParserContext
+        https://bugs.webkit.org/show_bug.cgi?id=222156
+
+        Reviewed by Carlos Garcia Campos.
+
+        * platform/glib/TestExpectations:
+
 2021-02-19  Aditya Keerthi  <akeerthi@apple.com>
 

trunk/LayoutTests/platform/glib/TestExpectations

@@ -664 +664 @@
 webkit.org/b/221311 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/filter/offscreencanvas.filter.w.html [ Slow ]
 webkit.org/b/221311 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/manual/filter/offscreencanvas.filter.w.html [ Slow ]
-
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.invalidstring.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.invalidtype.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-1.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-2.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-3.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-4.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-5.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-6.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-7.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-8.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsl-9.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-1.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-2.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-3.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-4.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-5.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-6.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-7.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-8.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-hsla-9.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-1.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-2.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-3.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-4.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-5.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgb-6.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.parse.css-color-4-rgba-1.worker.html [ Crash ]
-webkit.org/b/222156 [ Debug ] imported/w3c/web-platform-tests/html/canvas/offscreen/shadows/2d.shadow.attributes.shadowColor.invalid.worker.html [ Crash ]
 
 #////////////////////////////////////////////////////////////////////////////////////////

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-02-19  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        A number of offscreencanvas tests are asserting isMainThread trying to access strictCSSParserContext
+        https://bugs.webkit.org/show_bug.cgi?id=222156
+
+        Reviewed by Carlos Garcia Campos.
+
+        strictCSSParserContext() can be used only in the main thread.
+        It can't be used in parseColorWorkerSafe().
+
+        * css/parser/CSSParser.cpp:
+        (WebCore::CSSParser::parseColorWorkerSafe): Use
+        CSSParserContext(HTMLStandardMode) instead of
+        strictCSSParserContext().
+
 2021-02-19  Patrick Angle  <pangle@apple.com>
 

trunk/Source/WebCore/css/parser/CSSParser.cpp

@@ -118 +118 @@
     range.consumeWhitespace();
 
-    return CSSPropertyParserHelpers::consumeColorWorkerSafe(range, strictCSSParserContext());
+    return CSSPropertyParserHelpers::consumeColorWorkerSafe(range, CSSParserContext(HTMLStandardMode));
 }