Changeset 273219 in webkit

Timestamp:

Feb 21, 2021 9:20:47 AM (3 years ago)

Author:

commit-queue@webkit.org

Message:

Small improvements to r273073
​https://bugs.webkit.org/show_bug.cgi?id=222179

Patch by Martin Robinson <​mrobinson@igalia.com> on 2021-02-21
Reviewed by Darin Adler.

No new tests, because this should not change behavior.

• rendering/RenderObject.cpp:

(WebCore::RenderObject::enclosingScrollableContainerForSnapping const): Replace
a while loop with a for loop and prefer downcast<> to static_cast<>.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderObject.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-02-21  Martin Robinson  <mrobinson@igalia.com>
+
+        Small improvements to r273073
+        https://bugs.webkit.org/show_bug.cgi?id=222179
+
+        Reviewed by Darin Adler.
+
+        No new tests, because this should not change behavior.
+
+        * rendering/RenderObject.cpp:
+        (WebCore::RenderObject::enclosingScrollableContainerForSnapping const): Replace
+        a while loop with a for loop and prefer downcast<> to static_cast<>.
+
 2021-02-20  Chris Fleizach  <cfleizach@apple.com>
 

trunk/Source/WebCore/rendering/RenderObject.cpp

@@ -460 +460 @@
     // the containing block chain for positioned elements. This is important because
     // scrollable overflow does not establish a new containing block for children.
-    auto* candidate = container();
-    while (candidate) {
+    for (auto* candidate = container(); candidate; candidate = candidate->container()) {
         // Currently the RenderView can look like it has scrollable overflow, but we never
         // want to return this as our container. Instead we should use the root element.
@@ -467 +466 @@
             break;
         if (candidate->hasOverflowClip())
-            return static_cast<RenderBox*>(candidate);
-        candidate = candidate->container();
+            return downcast<RenderBox>(candidate);
     }