Changeset 273220 in webkit

Timestamp:

Feb 21, 2021 11:07:33 AM (3 years ago)

Author:

Noam Rosenthal

Message:

[Paint Timing] Return early from contentful paint check when no contentful pixels/characters at all
​https://bugs.webkit.org/show_bug.cgi?id=222245

Reviewed by Simon Fraser.

Bail from recursive contenful-paint check if there are no pixels/text characters in the entire document.

Covered by existing tests, an optimization only.

• dom/Document.cpp:

(WebCore::Document::enqueuePaintTimingEntryIfNeeded):

• page/FrameView.cpp:

(WebCore::FrameView::hasContenfulDescendants const):

• page/FrameView.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Document.cpp (modified) (1 diff)
• page/FrameView.cpp (modified) (1 diff)
• page/FrameView.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-02-21  Noam Rosenthal  <noam@webkit.org>
+
+        [Paint Timing] Return early from contentful paint check when no contentful pixels/characters at all
+        https://bugs.webkit.org/show_bug.cgi?id=222245
+
+        Reviewed by Simon Fraser.
+
+        Bail from recursive contenful-paint check if there are no pixels/text characters in the entire document.
+        
+        Covered by existing tests, an optimization only.
+
+        * dom/Document.cpp:
+        (WebCore::Document::enqueuePaintTimingEntryIfNeeded):
+        * page/FrameView.cpp:
+        (WebCore::FrameView::hasContenfulDescendants const):
+        * page/FrameView.h:
+
 2021-02-21  Martin Robinson  <mrobinson@igalia.com>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -3245 +3245 @@
         return;
 
+    if (!view()->hasContenfulDescendants())
+        return;
+
     if (!ContentfulPaintChecker::qualifiesForContentfulPaint(*view()))
         return;

trunk/Source/WebCore/page/FrameView.cpp

@@ -4617 +4617 @@
 }
 
+bool FrameView::hasContenfulDescendants() const
+{
+    return m_visuallyNonEmptyCharacterCount || m_visuallyNonEmptyPixelCount;
+}
+
 bool FrameView::isViewForDocumentInFrame() const
 {

trunk/Source/WebCore/page/FrameView.h

@@ -414 +414 @@
     void incrementVisuallyNonEmptyPixelCount(const IntSize&);
     bool isVisuallyNonEmpty() const { return m_contentQualifiesAsVisuallyNonEmpty; }
+    bool hasContenfulDescendants() const;
     void checkAndDispatchDidReachVisuallyNonEmptyState();