Changeset 273230 in webkit

Timestamp:

Feb 22, 2021 12:27:26 AM (3 years ago)

Author:

Fujii Hironori

Message:

RunLoop::threadWillExit is doing m_nextIteration.clear() without locking m_nextIterationLock
​https://bugs.webkit.org/show_bug.cgi?id=221115

Reviewed by Yusuke Suzuki.

GKT and WPE ports were observing a random assertion failure in
Deque::append in RunLoop::dispatch.

• wtf/RunLoop.cpp:

(WTF::RunLoop::threadWillExit): Lock m_nextIterationLock before doing m_nextIteration.clear().

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/RunLoop.cpp (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2021-02-22  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        RunLoop::threadWillExit is doing m_nextIteration.clear() without locking m_nextIterationLock
+        https://bugs.webkit.org/show_bug.cgi?id=221115
+
+        Reviewed by Yusuke Suzuki.
+
+        GKT and WPE ports were observing a random assertion failure in
+        Deque::append in RunLoop::dispatch.
+
+        * wtf/RunLoop.cpp:
+        (WTF::RunLoop::threadWillExit): Lock m_nextIterationLock before doing m_nextIteration.clear().
+
 2021-02-21  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WTF/wtf/RunLoop.cpp

@@ -175 +175 @@
 {
     m_currentIteration.clear();
-    m_nextIteration.clear();
+    {
+        auto locker = holdLock(m_nextIterationLock);
+        m_nextIteration.clear();
+    }
 }