Changeset 273314 in webkit


Ignore:
Timestamp:
Feb 23, 2021 9:50:31 AM (3 years ago)
Author:
commit-queue@webkit.org
Message:

aspect-ratio shows in computed style when disabled
​https://bugs.webkit.org/show_bug.cgi?id=222286

Patch by Rob Buis <​rbuis@igalia.com> on 2021-02-23
Reviewed by Simon Fraser.

Source/WebCore:

Make aspect-ratio invisible from style when disabled.

Test: fast/css/aspect-ratio-invalidate-if-disabled.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):

  • css/CSSProperties.json:

Tools:

Add support for disabling aspect-ratio in wk1.

  • DumpRenderTree/TestOptions.cpp:

(WTR::TestOptions::defaults):

LayoutTests:

Add test.

  • fast/css/aspect-ratio-invalidate-if-disabled-expected.txt: Added.
  • fast/css/aspect-ratio-invalidate-if-disabled.html: Added.
Location:
trunk
Files:
2 added
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r273309 r273314  
     12021-02-23  Rob Buis  <rbuis@igalia.com>
     2
     3        aspect-ratio shows in computed style when disabled
     4        https://bugs.webkit.org/show_bug.cgi?id=222286
     5
     6        Reviewed by Simon Fraser.
     7
     8        Add test.
     9
     10        * fast/css/aspect-ratio-invalidate-if-disabled-expected.txt: Added.
     11        * fast/css/aspect-ratio-invalidate-if-disabled.html: Added.
     12
    1132021-02-23  Philippe Normand  <pnormand@igalia.com>
    214

  • trunk/Source/WebCore/ChangeLog

    r273311 r273314  
     12021-02-23  Rob Buis  <rbuis@igalia.com>
     2
     3        aspect-ratio shows in computed style when disabled
     4        https://bugs.webkit.org/show_bug.cgi?id=222286
     5
     6        Reviewed by Simon Fraser.
     7
     8        Make aspect-ratio invisible from style when disabled.
     9
     10        Test: fast/css/aspect-ratio-invalidate-if-disabled.html
     11
     12        * css/CSSComputedStyleDeclaration.cpp:
     13        (WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
     14        * css/CSSProperties.json:
     15
    1162021-02-23  Xabier Rodriguez Calvar  <calvaris@igalia.com>
    217

  • trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp

    r272998 r273314  
    34623462            return cssValuePool.createValue(style.appearance());
    34633463        case CSSPropertyAspectRatio:
     3464            if (renderer && !renderer->settings().aspectRatioEnabled())
     3465                return nullptr;
    34643466            switch (style.aspectRatioType()) {
    34653467            case AspectRatioType::Auto:

  • trunk/Source/WebCore/css/CSSProperties.json

    r272987 r273314  
    45574557        "aspect-ratio": {
    45584558            "codegen-properties": {
    4559                 "custom": "All"
     4559                "custom": "All",
     4560                "settings-flag": "aspectRatio"
    45604561            },
    45614562            "status": {

  • trunk/Tools/ChangeLog

    r273308 r273314  
     12021-02-23  Rob Buis  <rbuis@igalia.com>
     2
     3        aspect-ratio shows in computed style when disabled
     4        https://bugs.webkit.org/show_bug.cgi?id=222286
     5
     6        Reviewed by Simon Fraser.
     7
     8        Add support for disabling aspect-ratio in wk1.
     9
     10        * DumpRenderTree/TestOptions.cpp:
     11        (WTR::TestOptions::defaults):
     12
    1132021-02-23  Chris Dumez  <cdumez@apple.com>
    214

  • trunk/Tools/DumpRenderTree/TestOptions.cpp

    r270613 r273314  
    7272            { "AllowUniversalAccessFromFileURLs", true },
    7373            { "AspectRatioOfImgFromWidthAndHeightEnabled", false },
     74            { "AspectRatioEnabled", true },
    7475            { "AsyncClipboardAPIEnabled", false },
    7576            { "AttachmentElementEnabled", false },
Note: See TracChangeset for help on using the changeset viewer.