Changeset 275451 in webkit

Timestamp:

Apr 5, 2021 4:43:41 PM (3 years ago)

Author:

Peng Liu

Message:

[GPUP][iPad] Audio only when airplaying a youtube video
​https://bugs.webkit.org/show_bug.cgi?id=224132

Reviewed by Eric Carlson.

While MediaPlayerPrivateAVFoundationObjC only implements setWirelessPlaybackTarget()
on macOS, MediaPlayerPrivateMediaSourceAVFObjC implements it on both macOS and iOS.
Therefore, RemoteMediaPlayerProxy has to forward the calls of setWirelessPlaybackTarget()
from WebContent processes to "MediaPlayerPrivate*" on both macOS and iOS.

Manually tested.

• GPUProcess/media/RemoteMediaPlayerProxy.cpp:

(WebKit::RemoteMediaPlayerProxy::setWirelessPlaybackTarget):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• GPUProcess/media/RemoteMediaPlayerProxy.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-04-05  Peng Liu  <peng.liu6@apple.com>
+
+        [GPUP][iPad] Audio only when airplaying a youtube video
+        https://bugs.webkit.org/show_bug.cgi?id=224132
+
+        Reviewed by Eric Carlson.
+
+        While `MediaPlayerPrivateAVFoundationObjC` only implements `setWirelessPlaybackTarget()`
+        on macOS, `MediaPlayerPrivateMediaSourceAVFObjC` implements it on both macOS and iOS.
+        Therefore, `RemoteMediaPlayerProxy` has to forward the calls of `setWirelessPlaybackTarget()`
+        from WebContent processes to "MediaPlayerPrivate*" on both macOS and iOS.
+
+        Manually tested.
+
+        * GPUProcess/media/RemoteMediaPlayerProxy.cpp:
+        (WebKit::RemoteMediaPlayerProxy::setWirelessPlaybackTarget):
+
 2021-04-02  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp

@@ -700 +700 @@
 void RemoteMediaPlayerProxy::setWirelessPlaybackTarget(const WebCore::MediaPlaybackTargetContext& targetContext)
 {
-#if !PLATFORM(IOS_FAMILY)
     switch (targetContext.type()) {
     case MediaPlaybackTargetContext::AVOutputContextType:
         m_player->setWirelessPlaybackTarget(WebCore::MediaPlaybackTargetCocoa::create(targetContext.avOutputContext()));
         break;
+#if PLATFORM(MAC)
     case MediaPlaybackTargetContext::MockType:
         m_player->setWirelessPlaybackTarget(WebCore::MediaPlaybackTargetMock::create(targetContext.mockDeviceName(), targetContext.mockState()));
         break;
+#else
+    case MediaPlaybackTargetContext::MockType:
+#endif
     case MediaPlaybackTargetContext::None:
         ASSERT_NOT_REACHED();
         break;
     }
-#else
-    UNUSED_PARAM(targetContext);
-#endif
 }
 #endif