Changeset 275466 in webkit
- Timestamp:
- Apr 5, 2021 6:06:22 PM (3 years ago)
- Location:
- trunk
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r275462 r275466 1 2021-04-05 Saam Barati <sbarati@apple.com> 2 3 Enable QuotaExceededError on non GSTREAMER platforms 4 https://bugs.webkit.org/show_bug.cgi?id=224136 5 <rdar://71219720> 6 7 Reviewed by Jer Noble. 8 9 * platform/mac/media/media-source/media-source-append-before-last-range-no-quota-exceeded-expected.txt: 10 1 11 2021-04-05 Cameron McCormack <heycam@apple.com> 2 12 -
trunk/LayoutTests/platform/mac/media/media-source/media-source-append-before-last-range-no-quota-exceeded-expected.txt
r270106 r275466 116 116 EVENT(updateend) 117 117 Appending PTS=176 118 EVENT(updateend) 119 EXPECTED (exception == 'QuotaExceededError: The quota has been exceeded.'), OBSERVED 'null' FAIL 120 EXPECTED (bufferedRanges() == '[ 120...176 ]'), OBSERVED '[ 120...177 ]' FAIL 118 EXPECTED (exception == 'QuotaExceededError: The quota has been exceeded.') OK 119 EXPECTED (bufferedRanges() == '[ 120...176 ]') OK 121 120 EXPECTED (video.currentTime == '115') OK 122 121 Appending PTS=115 -
trunk/Source/WebCore/ChangeLog
r275465 r275466 1 2021-04-05 Saam Barati <sbarati@apple.com> 2 3 Enable QuotaExceededError on non GSTREAMER platforms 4 https://bugs.webkit.org/show_bug.cgi?id=224136 5 <rdar://71219720> 6 7 Reviewed by Jer Noble. 8 9 This fixes a memory leak in Disney+ where we end up queuing up the entire 10 video because we never communicate to the page that they should stop queuing 11 more data. 12 13 * Modules/mediasource/SourceBuffer.cpp: 14 (WebCore::SourceBuffer::appendBufferInternal): 15 1 16 2021-04-05 Chris Dumez <cdumez@apple.com> 2 17 -
trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp
r274390 r275466 491 491 m_private->evictCodedFrames(size, m_pendingAppendData.capacity(), maximumBufferSize(), m_source->currentTime(), m_source->duration(), m_source->isEnded()); 492 492 493 // FIXME: enable this code when MSE libraries have been updated to support it.494 #if USE(GSTREAMER)495 493 // 5. If the buffer full flag equals true, then throw a QuotaExceededError exception and abort these step. 496 494 if (m_private->bufferFull()) { … … 498 496 return Exception { QuotaExceededError }; 499 497 } 500 #endif501 498 502 499 // NOTE: Return to 3.2 appendBuffer()
Note: See TracChangeset
for help on using the changeset viewer.