Changeset 275468 in webkit

Timestamp:

Apr 5, 2021 6:13:53 PM (3 years ago)

Author:

commit-queue@webkit.org

Message:

[ macOS ] media/webaudio-background-playback.html is a flakey text failure
​https://bugs.webkit.org/show_bug.cgi?id=221935
<rdar://problem/74370844>

Patch by Philippe Normand <​pnormand@igalia.com> on 2021-04-05
Reviewed by Eric Carlson.

The test was flaky because it was checking if the destination had processed new buffers
immediately after an asynchronous state change. The proposed solution is to monitor the
statechange event and do the actual test after another additional 100 milli-seconds have
passed.

• media/webaudio-background-playback.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• media/webaudio-background-playback.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-04-05  Philippe Normand  <pnormand@igalia.com>
+
+        [ macOS ] media/webaudio-background-playback.html is a flakey text failure
+        https://bugs.webkit.org/show_bug.cgi?id=221935
+        <rdar://problem/74370844>
+
+        Reviewed by Eric Carlson.
+
+        The test was flaky because it was checking if the destination had processed new buffers
+        immediately after an asynchronous state change. The proposed solution is to monitor the
+        statechange event and do the actual test after another additional 100 milli-seconds have
+        passed.
+
+        * media/webaudio-background-playback.html:
+
 2021-04-05  Saam Barati  <sbarati@apple.com>
 

trunk/LayoutTests/media/webaudio-background-playback.html

@@ -83 +83 @@
     assert_true(onProcessCount == oldOnProcessCount, "audio playback suspended in background");
 
+    // Context state changes are asynchronous, so delay the test to until the context has restarted + 100 additional milli-seconds.
+    context.onstatechange = () => {
+        setTimeout(() => {
+             assert_true(onProcessCount > oldOnProcessCount, "audio resumed playing in the foreground");
+        }, 100);
+    };
+
     if (window.internals)
         internals.applicationWillEnterForeground();
-    oldOnProcessCount = onProcessCount;
-    await new Promise(resolve => setTimeout(resolve, 100));
-    assert_true(onProcessCount > oldOnProcessCount, "audio resumed playing in the foreground");
-
 
 }, "Ensure WebAudio stops playing in the background when the 'BackgroundProcessPlaybackRestricted' restriction is set");