Changeset 275475 in webkit

Timestamp:

Apr 5, 2021 7:16:30 PM (3 years ago)

Author:

Chris Dumez

Message:

Make sure the Frame always gets destroyed on the main thread
​https://bugs.webkit.org/show_bug.cgi?id=224213
<rdar://75131946>

Reviewed by Alex Christensen.

Make sure the Frame always gets destroyed on the main thread.

Since ​http://trac.webkit.org/changeset/181791, Frame is ThreadSafeRefCounted and captured
on other threads. We should make sure the Frame is always destroyed on the main thread
though, since it is a main thread object and we hold WeakPtrs to it in many places.

• page/AbstractFrame.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/AbstractFrame.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-04-05  Chris Dumez  <cdumez@apple.com>
+
+        Make sure the Frame always gets destroyed on the main thread
+        https://bugs.webkit.org/show_bug.cgi?id=224213
+        <rdar://75131946>
+
+        Reviewed by Alex Christensen.
+
+        Make sure the Frame always gets destroyed on the main thread.
+
+        Since http://trac.webkit.org/changeset/181791, Frame is ThreadSafeRefCounted and captured
+        on other threads. We should make sure the Frame is always destroyed on the main thread
+        though, since it is a main thread object and we hold WeakPtrs to it in many places.
+
+        * page/AbstractFrame.h:
+
 2021-04-05  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/page/AbstractFrame.h

@@ -36 +36 @@
 
 // FIXME: Rename Frame to LocalFrame and AbstractFrame to Frame.
-class AbstractFrame : public ThreadSafeRefCounted<AbstractFrame>, public CanMakeWeakPtr<AbstractFrame> {
+class AbstractFrame : public ThreadSafeRefCounted<AbstractFrame, WTF::DestructionThread::Main>, public CanMakeWeakPtr<AbstractFrame> {
 public:
     virtual ~AbstractFrame();