Changeset 275538 in webkit

Timestamp:

Apr 6, 2021 12:38:33 PM (3 years ago)

Author:

eric.carlson@apple.com

Message:

[Cocoa] audio played at 2x speed video is not pitch corrected
​https://bugs.webkit.org/show_bug.cgi?id=224238
rdar://75868284

Reviewed by Jer Noble.

We need to use the _intended_ playback rate when deciding which pitch correction
algorithm to use. MediaPlayerPrivateAVFoundationObjC::m_cachedRate is used for this,
but r274592 stopped setting m_cachedRate in MediaPlayerPrivateAVFoundationObjC::setPlayerRate
because it is also set when AVPlayer KVOs that the rate changed.

Tested manually.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::setPlayerRate): Set m_cachedRate.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-04-06  Eric Carlson  <eric.carlson@apple.com>
+
+        [Cocoa] audio played at 2x speed video is not pitch corrected
+        https://bugs.webkit.org/show_bug.cgi?id=224238
+        rdar://75868284
+
+        Reviewed by Jer Noble.
+
+        We need to use the _intended_ playback rate when deciding which pitch correction
+        algorithm to use. MediaPlayerPrivateAVFoundationObjC::m_cachedRate is used for this,
+        but r274592 stopped setting m_cachedRate in MediaPlayerPrivateAVFoundationObjC::setPlayerRate
+        because it is also set when AVPlayer KVOs that the rate changed.
+
+        Tested manually.
+
+        * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+        (WebCore::MediaPlayerPrivateAVFoundationObjC::setPlayerRate): Set m_cachedRate.
+
 2021-04-06  David Kilzer  <ddkilzer@apple.com>
 

trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm

@@ -1514 +1514 @@
     setDelayCallbacks(true);
 
+    m_cachedRate = rate;
     [m_avPlayerItem setAudioTimePitchAlgorithm:audioTimePitchAlgorithmForMediaPlayerPitchCorrectionAlgorithm(player()->pitchCorrectionAlgorithm(), player()->preservesPitch(), m_cachedRate)];