Changeset 28233 in webkit

Timestamp:

Nov 30, 2007 9:02:48 AM (16 years ago)

Author:

adele@apple.com

Message:

WebCore:

Reviewed by Darin.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=16072
<rdar://problem/5463821> REGRESSION: Mousemove event isn't fired when mouse moves over scrollbar with pressed button (16072)

Test: fast/events/mousemove-after-drag-over-scrollbar.html

• page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent): If the mouse is pressed, and we've moved over a new scrollbar, then we can clear m_lastScrollbarUnderMouse. We should only need to show the hover effect when the mouse isn't pressed.

LayoutTests:

Reviewed by Darin.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=16072
<rdar://problem/5463821> REGRESSION: Mousemove event isn't fired when mouse moves over scrollbar with pressed button

• fast/events/mousemove-after-drag-over-scrollbar-expected.txt: Added.
• fast/events/mousemove-after-drag-over-scrollbar.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/events/mousemove-after-drag-over-scrollbar-expected.txt (added)
• LayoutTests/fast/events/mousemove-after-drag-over-scrollbar.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/page/EventHandler.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-11-30  Adele Peterson  <adele@apple.com>
+
+        Reviewed by Darin.
+
+        Test for http://bugs.webkit.org/show_bug.cgi?id=16072
+        <rdar://problem/5463821> REGRESSION: Mousemove event isn't fired when mouse moves over scrollbar with pressed button
+
+        * fast/events/mousemove-after-drag-over-scrollbar-expected.txt: Added.
+        * fast/events/mousemove-after-drag-over-scrollbar.html: Added.
+
 2007-11-30  Alexey Proskuryakov  <ap@webkit.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-11-30  Adele Peterson  <adele@apple.com>
+
+        Reviewed by Darin.
+
+        Fix for http://bugs.webkit.org/show_bug.cgi?id=16072
+        <rdar://problem/5463821> REGRESSION: Mousemove event isn't fired when mouse moves over scrollbar with pressed button (16072)
+
+        Test: fast/events/mousemove-after-drag-over-scrollbar.html
+
+        * page/EventHandler.cpp:
+        (WebCore::EventHandler::handleMouseMoveEvent): If the mouse is pressed, and we've moved over a new scrollbar, then we can clear m_lastScrollbarUnderMouse.
+         We should only need to show the hover effect when the mouse isn't pressed.
+
 2007-11-29  Brady Eidson <beidson@apple.com>
 

trunk/WebCore/page/EventHandler.cpp

@@ -1013 +1013 @@
             if (m_lastScrollbarUnderMouse)
                 m_lastScrollbarUnderMouse->handleMouseOutEvent(mouseEvent);
-            m_lastScrollbarUnderMouse = scrollbar;
+            m_lastScrollbarUnderMouse = m_mousePressed ? 0 : scrollbar;
         }
     }