Changeset 28811 in webkit

Timestamp:

Dec 17, 2007 9:53:23 AM (16 years ago)

Author:

Darin Adler

Message:

Reviewed by Mark Rowe.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=16468 REGRESSION(r28781): Crash running storage/transaction_callback_exception_crash.html

• storage/DatabaseThread.cpp: (WebCore::DatabaseThread::dispatchNextTaskIdentifier): Use a RefPtr for the database because there's no guarantee it won't lose its last reference otherwise.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• storage/DatabaseThread.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-12-17  Darin Adler  <darin@apple.com>
+
+        Reviewed by Mark Rowe.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=16468
+          REGRESSION(r28781): Crash running storage/transaction_callback_exception_crash.html
+
+        * storage/DatabaseThread.cpp:
+        (WebCore::DatabaseThread::dispatchNextTaskIdentifier): Use a RefPtr for the database
+        because there's no guarantee it won't lose its last reference otherwise.
+
 2007-12-17  Dan Bernstein  <mitz@apple.com>
 

trunk/WebCore/storage/DatabaseThread.cpp

@@ -156 +156 @@
 bool DatabaseThread::dispatchNextTaskIdentifier()
 {
-    Database* workDatabase = 0;
+    RefPtr<Database> workDatabase;
     RefPtr<DatabaseTask> task;
 
@@ -180 +180 @@
         ASSERT(workDatabase);
         workDatabase->resetAuthorizer();
-        task->performTask(workDatabase);
+        task->performTask(workDatabase.get());
         return true;
     }