Changeset 28888 in webkit


Ignore:
Timestamp:
Dec 20, 2007 10:09:31 AM (16 years ago)
Author:
alp@webkit.org
Message:

2007-12-17 Tony Chang <​idealisms@gmail.com>

Reviewed by Darin.

Test: fast/text/reset-drag-on-mouse-down.html

Location:
trunk
Files:
2 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r28884 r28888  
     12007-12-17  Tony Chang  <idealisms@gmail.com>
     2
     3        Reviewed by Darin.
     4
     5        Test for http://bugs.webkit.org/show_bug.cgi?id=16479
     6        Reset the drag state on non-mac platforms.
     7
     8        * fast/text/reset-drag-on-mouse-down.html: Added.
     9        * platform/mac/fast/text/reset-drag-on-mouse-down-expected.txt: Added.
     10
    1112007-12-19  Geoffrey Garen  <ggaren@apple.com>
    212

  • trunk/WebCore/ChangeLog

    r28884 r28888  
     12007-12-17  Tony Chang  <idealisms@gmail.com>
     2
     3        Reviewed by Darin.
     4
     5        - Fix for http://bugs.webkit.org/show_bug.cgi?id=16479
     6          text selection does not always begin at mouse down point
     7          Reset the m_dragSrc object on mouse down on all platforms.
     8
     9        Test: fast/text/reset-drag-on-mouse-down.html
     10
     11        * page/EventHandler.cpp:
     12        (WebCore::EventHandler::handleMousePressEvent):
     13        * page/mac/EventHandlerMac.mm:
     14        (WebCore::EventHandler::mouseDown):
     15
    1162007-12-19  Geoffrey Garen  <ggaren@apple.com>
    217

  • trunk/WebCore/page/EventHandler.cpp

    r28813 r28888  
    293293bool EventHandler::handleMousePressEvent(const MouseEventWithHitTestResults& event)
    294294{
     295    // Reset drag state.
     296    dragState().m_dragSrc = 0;
     297
    295298    bool singleClick = event.event().clickCount() <= 1;
    296299

  • trunk/WebCore/page/mac/EventHandlerMac.mm

    r28717 r28888  
    471471
    472472    m_mouseDownView = nil;
    473     dragState().m_dragSrc = 0;
    474473   
    475474    RetainPtr<NSEvent> oldCurrentEvent = currentEvent();
Note: See TracChangeset for help on using the changeset viewer.