Changeset 29472 in webkit

Timestamp:

Jan 14, 2008 10:28:43 AM (16 years ago)

Author:

kmccullough@apple.com

Message:

JavaScriptCore:

Reviewed by Oliver.

-<rdar://problem/5622667> REGRESSION (Leopard-ToT): Endless loading loop
trying to view techreport.com comments

• We need to set values in the map, because if they are already in the map they will not be reset when we use add().

• kjs/array_instance.cpp: (KJS::ArrayInstance::put):

LayoutTests:

Reviewed by Oliver.

• <rdar://problem/5622667> REGRESSION (Leopard-ToT): Endless loading loop trying to view techreport.com comments
• Any resetting of a value in an array of sufficient size, would cause the second value to be lost.

• fast/js/array-reset-large-index-expected.txt: Added.
• fast/js/array-reset-large-index.html: Added.
• fast/js/resources/array-reset-large-index.js: Added.

Location:

trunk

Files:

• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/kjs/array_instance.cpp (modified) (2 diffs)
• LayoutTests/ChangeLog (modified) (2 diffs)
• LayoutTests/fast/js/array-reset-large-index-expected.txt (added)
• LayoutTests/fast/js/array-reset-large-index.html (added)
• LayoutTests/fast/js/resources/array-reset-large-index.js (added)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-01-14  Kevin McCullough  <kmccullough@apple.com>
+
+        Reviewed by Oliver.
+
+        -<rdar://problem/5622667> REGRESSION (Leopard-ToT): Endless loading loop
+        trying to view techreport.com comments
+        - We need to set values in the map, because if they are already in the
+        map they will not be reset when we use add().
+
+        * kjs/array_instance.cpp:
+        (KJS::ArrayInstance::put):
+
 2008-01-14  Darin Adler  <darin@apple.com>
 

trunk/JavaScriptCore/kjs/array_instance.cpp

@@ -250 +250 @@
             storage->m_sparseValueMap = map;
         }
-        map->add(i, value);
+        map->set(i, value);
         return;
     }
@@ -256 +256 @@
     unsigned newNumValuesInVector = storage->m_numValuesInVector + 1;
     if (!isDenseEnoughForVector(i + 1, newNumValuesInVector)) {
-        map->add(i, value);
+        map->set(i, value);
         return;
     }

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2008-01-11  Kevin McCullough  <kmccullough@apple.com>
+
+        Reviewed by Oliver.
+
+        - <rdar://problem/5622667> REGRESSION (Leopard-ToT): Endless loading
+        loop trying to view techreport.com comments
+        - Any resetting of a value in an array of sufficient size, would cause
+        the second value to be lost.
+
+        * fast/js/array-reset-large-index-expected.txt: Added.
+        * fast/js/array-reset-large-index.html: Added.
+        * fast/js/resources/array-reset-large-index.js: Added.
+
 2008-01-14  Adam Roben  <aroben@apple.com>
 
@@ -8965 +8978 @@
         - test for http://bugs.webkit.org/show_bug.cgi?id=15181
           text-transform: uppercase not working in input (submit, reset, button) elements
-          <rdar://problem/5474647>
+          rdar://problem/5474647>
 
         * fast/forms/button-text-transform.html: Added.