Changeset 29850 in webkit

Timestamp:

Jan 29, 2008 2:22:21 PM (16 years ago)

Author:

eric@webkit.org

Message:

Reviewed by Nikolas.

Acid3 after double-attach
​http://bugs.webkit.org/show_bug.cgi?id=17058

I believe SVGTextPathElement::buildPendingResource() was entirely
bogus, removing it did not cause any tests to fail.

Test: svg/custom/textPath-assert.svg

• svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::insertedIntoDocument): remove buildPendingResource()
• svg/SVGTextPathElement.h:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/custom/textPath-assert-expected.txt (added)
• LayoutTests/svg/custom/textPath-assert.svg (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/svg/SVGTextPathElement.cpp (modified) (1 diff)
• WebCore/svg/SVGTextPathElement.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2008-01-29  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Nikolas.
+        
+        Acid3 after double-attach
+        http://bugs.webkit.org/show_bug.cgi?id=17058
+
+        * svg/custom/textPath-assert-expected.txt: Added.
+        * svg/custom/textPath-assert.svg: Added.
+
 2008-01-29  Adam Roben  <aroben@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-01-29  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Nikolas.
+
+        Acid3 after double-attach
+        http://bugs.webkit.org/show_bug.cgi?id=17058
+        
+        I believe SVGTextPathElement::buildPendingResource() was entirely
+        bogus, removing it did not cause any tests to fail.
+
+        Test: svg/custom/textPath-assert.svg
+
+        * svg/SVGTextPathElement.cpp:
+        (WebCore::SVGTextPathElement::insertedIntoDocument): remove buildPendingResource()
+        * svg/SVGTextPathElement.h:
+
 2008-01-29  Adam Roben  <aroben@apple.com>
 

trunk/WebCore/svg/SVGTextPathElement.cpp

@@ -100 +100 @@
         return;
     }
-
-    buildPendingResource();
-}
-
-void SVGTextPathElement::buildPendingResource()
-{
-    // FIXME: Real logic here!
-    if (attached())
-        detach();
-    
-    ASSERT(!attached());
-    attach();
 }
 

trunk/WebCore/svg/SVGTextPathElement.h

@@ -60 +60 @@
  
         virtual void insertedIntoDocument();
-        virtual void buildPendingResource();
 
         virtual void parseMappedAttribute(MappedAttribute* attr);