Changeset 30191 in webkit

Timestamp:

Feb 13, 2008 1:51:59 AM (16 years ago)

Author:

oliver@apple.com

Message:

<rdar://problem/5737003> REGRESSION (r27747): can't browse pictures on fastcupid.com

Reviewed by Alexey P.

When converting numeric values to booleans we need to account for NaN

Location:

trunk

Files:

• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/kjs/nodes.cpp (modified) (2 diffs)
• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/js/convert-nan-to-bool-expected.txt (added)
• LayoutTests/fast/js/convert-nan-to-bool.html (added)
• LayoutTests/fast/js/resources/convert-nan-to-bool.js (added)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-02-13  Oliver Hunt  <oliver@apple.com>
+
+        Reviewed by Alexey P.
+
+        <rdar://problem/5737003> REGRESSION (r27747): can't browse pictures on fastcupid.com
+
+        When converting numeric values to booleans we need to account for NaN
+
+        * kjs/nodes.cpp:
+        (KJS::MultNode::evaluateToBoolean):
+        (KJS::ModNode::evaluateToBoolean):
+
 2008-02-08  Samuel Weinig  <sam@webkit.org>
 

trunk/JavaScriptCore/kjs/nodes.cpp

@@ -2136 +2136 @@
 bool MultNode::evaluateToBoolean(ExecState* exec)
 {
-    return inlineEvaluateToNumber(exec);
+    double result = inlineEvaluateToNumber(exec);
+    return  result > 0.0 || 0.0 > result; // NaN produces false as well
 }
 
@@ -2211 +2212 @@
 bool ModNode::evaluateToBoolean(ExecState* exec)
 {
-    return inlineEvaluateToNumber(exec);
+    double result = inlineEvaluateToNumber(exec);
+    return  result > 0.0 || 0.0 > result; // NaN produces false as well
 }
 

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2008-02-13  Oliver Hunt  <oliver@apple.com>
+
+        Reviewed by Alexey P.
+
+        Tests for <rdar://problem/5737003> REGRESSION (r27747): can't browse pictures on fastcupid.com
+
+        Ensure that the basic arithmetic operands can correctly handle the NaN -> boolean conversion
+
+        * fast/js/convert-nan-to-bool.html: Added.
+        * fast/js/convert-nan-to-bool-expected.txt: Added.
+        * fast/js/resources/convert-nan-to-bool.js: Added.
+
 2008-02-12  Dan Bernstein  <mitz@apple.com>