Changeset 30790 in webkit

Timestamp:

Mar 4, 2008 11:08:43 PM (16 years ago)

Author:

mjs@apple.com

Message:

WebCore:

Reviewed by Sam and Oliver.

• fixed ​http://bugs.webkit.org/show_bug.cgi?id=16289
• fixed Acid3 tests 26 and 27 (not exactly the same issue but related)

• bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::mark): When marking a node that's in-document, mark the owner document if it hasn't been already. This means holding on to a single node from an unreferenced document now keeps the whole document alive.

We are now at 90/100 on Acid3.

LayoutTests:

Reviewed by Sam and Oliver.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=16289
• test for Acid3 tests 26 and 27 (not exactly the same issue but related)

• fast/dom/gc-11-expected.txt: Added. Test case from bug 16289.
• fast/dom/gc-11.html: Added.
• fast/dom/gc-acid3.html: Added. DOM garbage collection part of Acid3.
• fast/dom/gc-acid3-expected.txt: Added.
• fast/dom/gc-6-expected.txt: Updated results. The old assumptions of this test were in conflict with the requirements of Acid3.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/dom/gc-11-expected.txt (added)
• LayoutTests/fast/dom/gc-11.html (added)
• LayoutTests/fast/dom/gc-6-expected.txt (modified) (1 diff)
• LayoutTests/fast/dom/gc-acid3-expected.txt (added)
• LayoutTests/fast/dom/gc-acid3.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/bindings/js/JSNodeCustom.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2008-03-04  Maciej Stachowiak  <mjs@apple.com>
+
+        Reviewed by Sam and Oliver.
+
+        - test for http://bugs.webkit.org/show_bug.cgi?id=16289
+        - test for Acid3 tests 26 and 27 (not exactly the same issue but related)
+
+        * fast/dom/gc-11-expected.txt: Added. Test case from bug 16289.
+        * fast/dom/gc-11.html: Added.
+        * fast/dom/gc-acid3.html: Added. DOM garbage collection part of Acid3.
+        * fast/dom/gc-acid3-expected.txt: Added.
+        * fast/dom/gc-6-expected.txt: Updated results. The old assumptions of this test
+        were in conflict with the requirements of Acid3.
+
 2008-03-04  Dan Bernstein  <mitz@apple.com>
 

trunk/LayoutTests/fast/dom/gc-6-expected.txt

@@ -5 +5 @@
 B
 [object HTMLElement]
-null
+[object HTMLElement]
 [object HTMLDocument]
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-03-04  Maciej Stachowiak  <mjs@apple.com>
+
+        Reviewed by Sam and Oliver.
+
+        - fixed http://bugs.webkit.org/show_bug.cgi?id=16289
+        - fixed Acid3 tests 26 and 27 (not exactly the same issue but related)
+
+        * bindings/js/JSNodeCustom.cpp:
+        (WebCore::JSNode::mark): When marking a node that's in-document,
+        mark the owner document if it hasn't been already. This means holding on
+        to a single node from an unreferenced document now keeps the whole document alive.
+        
+        We are now at 90/100 on Acid3.
+
 2008-03-04  Sam Weinig  <sam@webkit.org>
 

trunk/WebCore/bindings/js/JSNodeCustom.cpp

@@ -116 +116 @@
     // so we have no special responsibilities and can just call the base class here.
     if (node->inDocument()) {
+        // But if the document isn't marked we have to mark it to ensure that
+        // nodes reachable from this one are also marked
+        if (Document* doc = node->ownerDocument())
+            if (DOMObject* docWrapper = ScriptInterpreter::getDOMObject(doc))
+                if (!docWrapper->marked())
+                    docWrapper->mark();
         DOMObject::mark();
         return;