Changeset 31024 in webkit

Timestamp:

Mar 12, 2008 11:13:02 PM (16 years ago)

Author:

Adam Roben

Message:

Update the styles/metrics panes and breadcrumb after editing DOM attributes

Reviewed by Tim.

• page/inspector/DocumentPanel.js: (WebInspector.DocumentPanel.set focusedDOMNode): Moved code to update the parts of the DocumentPanel other than the DOM tree into a new function, _focusedNodeChanged. (WebInspector.DocumentPanel._focusedNodeChanged): Added. The forceUpdate parameter specifies whether the update should occur even if the focused node hasn't changed since the last update. (WebInspector.DocumentPanel.updateBreadcrumb): Added a forceUpdate parameter. If forceUpdate is true, we always rebuild the breadcrumbs. (WebInspector.DocumentPanel.updateStyles): Added a forceUpdate parameter. If forceUpdate is true, we always rebuild the styles pane. (WebInspector.DOMNodeTreeElement._attributeEditingCommitted): Added a call to DocumentPanel._focusedNodeChanged. We have to force the update because we haven't changed the focused node (the attributes of the node have changed).
• page/inspector/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.update): Added a forceUpdate parameter. If forceUpdate is true we always rebuild the styles.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/inspector/DocumentPanel.js (modified) (7 diffs)
• page/inspector/StylesSidebarPane.js (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-03-12  Adam Roben  <aroben@apple.com>
+
+        Update the styles/metrics panes and breadcrumb after editing DOM
+        attributes
+
+        Reviewed by Tim.
+
+        * page/inspector/DocumentPanel.js:
+        (WebInspector.DocumentPanel.set focusedDOMNode): Moved code to update
+        the parts of the DocumentPanel other than the DOM tree into a new
+        function, _focusedNodeChanged.
+        (WebInspector.DocumentPanel._focusedNodeChanged): Added. The
+        forceUpdate parameter specifies whether the update should occur even
+        if the focused node hasn't changed since the last update.
+        (WebInspector.DocumentPanel.updateBreadcrumb): Added a forceUpdate
+        parameter. If forceUpdate is true, we always rebuild the breadcrumbs.
+        (WebInspector.DocumentPanel.updateStyles): Added a forceUpdate
+        parameter. If forceUpdate is true, we always rebuild the styles pane.
+        (WebInspector.DOMNodeTreeElement._attributeEditingCommitted): Added a
+        call to DocumentPanel._focusedNodeChanged. We have to force the update
+        because we haven't changed the focused node (the attributes of the
+        node have changed).
+        * page/inspector/StylesSidebarPane.js:
+        (WebInspector.StylesSidebarPane.update): Added a forceUpdate
+        parameter. If forceUpdate is true we always rebuild the styles.
+
 2008-03-12  Mark Rowe  <mrowe@apple.com>
 

trunk/WebCore/page/inspector/DocumentPanel.js

@@ -140 +140 @@
         this._focusedDOMNode = x;
 
-        this.updateBreadcrumb();
-
-        for (var pane in this.views.dom.sidebarPanes)
-            this.views.dom.sidebarPanes[pane].needsUpdate = true;
-
-        this.updateStyles();
-        this.updateMetrics();
-        this.updateProperties();
+        this._focusedNodeChanged();
 
         InspectorController.highlightDOMNode(x);
@@ -154 +147 @@
         if (nodeItem)
             nodeItem.select();
+    },
+
+    _focusedNodeChanged: function(forceUpdate)
+    {
+        this.updateBreadcrumb(forceUpdate);
+
+        for (var pane in this.views.dom.sidebarPanes)
+            this.views.dom.sidebarPanes[pane].needsUpdate = true;
+
+        this.updateStyles(forceUpdate);
+        this.updateMetrics();
+        this.updateProperties();
     },
 
@@ -183 +188 @@
     },
 
-    updateBreadcrumb: function()
+    updateBreadcrumb: function(forceUpdate)
     {
         if (!this.visible)
@@ -212 +217 @@
         }
 
-        if (handled) {
+        if (handled && !forceUpdate) {
             // We don't need to rebuild the crumbs, but we need to adjust sizes
             // to reflect the new focused or root node.
@@ -631 +636 @@
     },
 
-    updateStyles: function()
+    updateStyles: function(forceUpdate)
     {
         var stylesSidebarPane = this.views.dom.sidebarPanes.styles;
@@ -637 +642 @@
             return;
 
-        stylesSidebarPane.update(this.focusedDOMNode);
+        stylesSidebarPane.update(this.focusedDOMNode, undefined, forceUpdate);
         stylesSidebarPane.needsUpdate = false;
     },
@@ -973 +978 @@
 
         this._updateTitle();
+        this.treeOutline.panel._focusedNodeChanged(true);
     },
 

trunk/WebCore/page/inspector/StylesSidebarPane.js

@@ -33 +33 @@
 
 WebInspector.StylesSidebarPane.prototype = {
-    update: function(node, editedSection)
+    update: function(node, editedSection, forceUpdate)
     {
         var refresh = false;
 
-        if (!node || node === this.node)
+        if (!forceUpdate && (!node || node === this.node))
             refresh = true;