Changeset 31238 in webkit

Timestamp:

Mar 23, 2008 2:08:40 PM (16 years ago)

Author:

eric@webkit.org

Message:

Reviewed by eseidel. Landed by eseidel.

Bug 17685: [~=] attribute selector failing to match empty string
<​http://bugs.webkit.org/show_bug.cgi?id=17685>

Test: fast/css/attribute-selector-empty-value.html

• css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkOneSelector):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css/attribute-selector-empty-value.html (added)
• LayoutTests/platform/mac/fast/css/attribute-selector-empty-value-expected.txt (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/css/CSSStyleSelector.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2008-03-23  Robert Blaut  <webkit@blaut.biz>
+
+        Reviewed by eseidel.  Landed by eseidel.
+
+        Test to ensure [~=] attribute selector doesn't match empty string
+
+        * fast/css/attribute-selector-empty-value.html: Added.
+
 2008-03-23  Oliver Hunt  <oliver@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-03-23  Robert Blaut  <webkit@blaut.biz>
+
+        Reviewed by eseidel.  Landed by eseidel.
+
+        Bug 17685: [~=] attribute selector failing to match empty string
+        <http://bugs.webkit.org/show_bug.cgi?id=17685>
+
+        Test: fast/css/attribute-selector-empty-value.html
+
+        * css/CSSStyleSelector.cpp:
+        (WebCore::CSSStyleSelector::checkOneSelector):
+
 2008-03-22  Marco Barisione  <marco.barisione@collabora.co.uk>
 

trunk/WebCore/css/CSSStyleSelector.cpp

@@ -1465 +1465 @@
         case CSSSelector::List:
         {
-            // The selector's value can't contain a space, or it's totally bogus.
-            if (sel->m_value.contains(' '))
+            // Ignore empty selectors or selectors containing spaces
+            if (sel->m_value.contains(' ') || sel->m_value.isEmpty())
                 return false;