Changeset 31320 in webkit

Timestamp:

Mar 26, 2008 10:49:32 AM (16 years ago)

Author:

Adam Roben

Message:

Fix Bug 17768: REGRESSION (r30146): Inspector no longer shows elements properties

<​http://bugs.webkit.org/show_bug.cgi?id=17768>

We were throwing an exception from Object.describe because of some
undefined variables.

Reviewed by Tim Hatcher.

• page/inspector/utilities.js: (Object.describe): Reinstate the type1 and type2 variables that were removed in r30146. They're still used when formatting a function.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/inspector/utilities.js (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-03-26  Adam Roben  <aroben@apple.com>
+
+        Fix Bug 17768: REGRESSION (r30146): Inspector no longer shows elements
+        properties
+
+        <http://bugs.webkit.org/show_bug.cgi?id=17768>
+
+        We were throwing an exception from Object.describe because of some
+        undefined variables.
+
+        Reviewed by Tim Hatcher.
+
+        * page/inspector/utilities.js:
+        (Object.describe): Reinstate the type1 and type2 variables that were
+        removed in r30146. They're still used when formatting a function.
+
 2008-03-26  Eric Seidel  <eric@webkit.org>
 

trunk/WebCore/page/inspector/utilities.js

@@ -55 +55 @@
 Object.describe = function(obj, abbreviated)
 {
-    switch (Object.type(obj)) {
+    var type1 = Object.type(obj);
+    var type2 = Object.prototype.toString.call(obj).replace(/^\[object (.*)\]$/i, "$1");
+
+    switch (type1) {
     case "object":
-        return Object.prototype.toString.call(obj).replace(/^\[object (.*)\]$/i, "$1");
+        return type2;
     case "array":
         return "[" + obj.toString() + "]";