Changeset 31644 in webkit

Timestamp:

Apr 4, 2008 1:29:47 PM (16 years ago)

Author:

timothy@apple.com

Message:

Makes setting shouldRefreshChildren on a TreeElement perform the refresh
immediately if the element is already expanded.

Reviewed by Adam Roben.

• page/inspector/treeoutline.js:

(TreeElement.prototype.get shouldRefreshChildren): Return this._shouldRefreshChildren.
(TreeElement.prototype.set shouldRefreshChildren): If changing to true, and
already expanded,
call expand again to trigger the refresh. Sets this._shouldRefreshChildren.
(TreeElement.prototype._attach): Check for this._shouldRefreshChildren.
(TreeElement.prototype.expand): Ditto.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/inspector/treeoutline.js (modified) (4 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-04-04  Timothy Hatcher  <timothy@apple.com>
+
+        Makes setting shouldRefreshChildren on a TreeElement perform the refresh
+        immediately if the element is already expanded.
+
+        Reviewed by Adam Roben.
+
+        * page/inspector/treeoutline.js:
+        (TreeElement.prototype.get shouldRefreshChildren): Return this._shouldRefreshChildren.
+        (TreeElement.prototype.set shouldRefreshChildren): If changing to true, and
+        already expanded,
+        call expand again to trigger the refresh. Sets this._shouldRefreshChildren.
+        (TreeElement.prototype._attach): Check for this._shouldRefreshChildren.
+        (TreeElement.prototype.expand): Ditto.
+
 2008-04-04  Jon Honeycutt  <jhoneycutt@apple.com>
 

trunk/WebCore/page/inspector/treeoutline.js

@@ -461 +461 @@
                 this._childrenListNode.removeStyleClass("hidden");
         }
+    },
+
+    get shouldRefreshChildren() {
+        return this._shouldRefreshChildren;
+    },
+
+    set shouldRefreshChildren(x) {
+        this._shouldRefreshChildren = x;
+        if (x && this.expanded)
+            this.expand();
     }
 }
@@ -472 +482 @@
 TreeElement.prototype._attach = function()
 {
-    if (!this._listItemNode || this.parent.refreshChildren) {
+    if (!this._listItemNode || this.parent._shouldRefreshChildren) {
         if (this._listItemNode && this._listItemNode.parentNode)
             this._listItemNode.parentNode.removeChild(this._listItemNode);
@@ -588 +598 @@
 TreeElement.prototype.expand = function()
 {
-    if (!this.hasChildren || (this.expanded && !this.refreshChildren && this._childrenListNode))
-        return;
-
-    if (!this._childrenListNode || this.refreshChildren) {
+    if (!this.hasChildren || (this.expanded && !this._shouldRefreshChildren && this._childrenListNode))
+        return;
+
+    if (!this._childrenListNode || this._shouldRefreshChildren) {
         if (this._childrenListNode && this._childrenListNode.parentNode)
             this._childrenListNode.parentNode.removeChild(this._childrenListNode);
@@ -608 +618 @@
             this.children[i]._attach();
 
-        delete this.refreshChildren;
+        delete this._shouldRefreshChildren;
     }