Changeset 31959 in webkit

Timestamp:

Apr 16, 2008 1:22:53 PM (16 years ago)

Author:

Adam Roben

Message:

Fix console-log-formatting to truly test formatting an undefined value

Exceptions thrown by the test will also now be shown as errors.

Reviewed by Tim Hatcher.

• manual-tests/inspector/console-log-formatting.html: (test): Use console.error to report exceptions. (runTests): Use window.noSuchVariable instead of just noSuchVariable to avoid an exception.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• manual-tests/inspector/console-log-formatting.html (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-04-16  Adam Roben  <aroben@apple.com>
+
+        Fix console-log-formatting to truly test formatting an undefined value
+
+        Exceptions thrown by the test will also now be shown as errors.
+
+        Reviewed by Tim Hatcher.
+
+        * manual-tests/inspector/console-log-formatting.html:
+        (test): Use console.error to report exceptions.
+        (runTests): Use window.noSuchVariable instead of just noSuchVariable
+        to avoid an exception.
+
 2008-04-16  Anatoli Papirovski  <apapirovski@mac.com>
 

trunk/WebCore/manual-tests/inspector/console-log-formatting.html

@@ -20 +20 @@
             eval("console.log(" + args + ")");
         } catch (e) {
-            console.log("%o", e);
+            console.error(e);
         }
     }
@@ -31 +31 @@
     function runTests() {
         var values = [
-            { value: "noSuchVariable", description: "undefined" },
+            { value: "window.noSuchVariable", description: "undefined" },
             { value: "s", description: "string" },
             { value: "i", description: "positive integer" },