Changeset 32528 in webkit

Timestamp:

Apr 24, 2008 5:58:11 PM (16 years ago)

Author:

mrowe@apple.com

Message:

2008-04-24 Cameron McCormack <​cam@mcc.id.au>

Reviewed by Maciej Stachowiak.

Ensure that changes to rx="" and ry="" attributes on an SVG <rect>
element cause a relayout.

Test: svg/dom/SVGRectElement/rect-modify-rx.svg

• svg/SVGRectElement.cpp: (WebCore::SVGRectElement::svgAttributeChanged): Call needsLayout() when the attribute is rx or ry. (WebCore::SVGRectElement::hasRelativeValues): Return true when the attribute is rx or ry, since they also can have relative values.

2008-04-24 Cameron McCormack <​cam@mcc.id.au>

Reviewed by Maciej Stachowiak.

Test for:
​http://bugs.webkit.org/show_bug.cgi?id=18328
Modifying rx="" or ry="" on a <rect> doesn't relayout

• svg/dom/SVGRectElement: Added.
• svg/dom/SVGRectElement/rect-modify-rx-expected.txt: Added.
• svg/dom/SVGRectElement/rect-modify-rx.svg: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/dom/SVGRectElement (added)
• LayoutTests/svg/dom/SVGRectElement/rect-modify-rx-expected.txt (added)
• LayoutTests/svg/dom/SVGRectElement/rect-modify-rx.svg (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/svg/SVGRectElement.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2008-04-24  Cameron McCormack  <cam@mcc.id.au>
+
+        Reviewed by Maciej Stachowiak.
+
+        Test for:
+        http://bugs.webkit.org/show_bug.cgi?id=18328
+        Modifying rx="" or ry="" on a <rect> doesn't relayout
+
+        * svg/dom/SVGRectElement: Added.
+        * svg/dom/SVGRectElement/rect-modify-rx-expected.txt: Added.
+        * svg/dom/SVGRectElement/rect-modify-rx.svg: Added.
+
 2008-04-24  Adam Barth  <hk9565@gmail.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-04-24  Cameron McCormack  <cam@mcc.id.au>
+
+        Reviewed by Maciej Stachowiak.
+
+        Ensure that changes to rx="" and ry="" attributes on an SVG <rect>
+        element cause a relayout.
+
+        Test: svg/dom/SVGRectElement/rect-modify-rx.svg
+
+        * svg/SVGRectElement.cpp:
+        (WebCore::SVGRectElement::svgAttributeChanged): Call needsLayout()
+        when the attribute is rx or ry.
+        (WebCore::SVGRectElement::hasRelativeValues): Return true when the
+        attribute is rx or ry, since they also can have relative values.
+
 2008-04-24  Adam Barth  <hk9565@gmail.com>
 

trunk/WebCore/svg/SVGRectElement.cpp

@@ -99 +99 @@
     if (attrName == SVGNames::xAttr || attrName == SVGNames::yAttr ||
         attrName == SVGNames::widthAttr || attrName == SVGNames::heightAttr ||
+        attrName == SVGNames::rxAttr || attrName == SVGNames::ryAttr ||
         SVGTests::isKnownAttribute(attrName) ||
         SVGLangSpace::isKnownAttribute(attrName) ||
@@ -124 +125 @@
 {
     return (x().isRelative() || width().isRelative() ||
-            y().isRelative() || height().isRelative());
+            y().isRelative() || height().isRelative() ||
+            rx().isRelative() || ry().isRelative());
 }