Changeset 32664 in webkit
- Timestamp:
- Apr 28, 2008 6:18:52 PM (16 years ago)
- Location:
- trunk
- Files:
-
- 8 added
- 34 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r32660 r32664 1 2008-04-28 Alice Liu <alice.liu@apple.com> 2 3 Reviewed by Sam Weinig. 4 5 Fix <rdar://problem/4911289> Add tabindex property to all children 6 of HTMLElement (7138) 7 http://bugs.webkit.org/show_bug.cgi?id=7138 8 9 minor updates to these existing tests: 10 * fast/dom/domListEnumeration-expected.txt: 11 * fast/dom/plugin-attributes-enumeration-expected.txt: 12 * fast/dom/resources/domListEnumeration.js: 13 14 * fast/events/resources/abe.png: Added. 15 * fast/events/resources/tabindex-focus-blur-all-frame1.html: Added. 16 * fast/events/resources/tabindex-focus-blur-all-frame2.html: Added. 17 * fast/events/resources/tabindex-focus-blur-all-iframe1.html: Added. 18 * fast/events/resources/tabindex-focus-blur-all-iframe2.html: Added. 19 * fast/events/resources/tabindex-focus-blur-all.js: Added. 20 * fast/events/tabindex-focus-blur-all-expected.txt: Added. 21 * fast/events/tabindex-focus-blur-all.html: Added. 22 1 23 2008-04-28 Dan Bernstein <mitz@apple.com> 2 24 -
trunk/LayoutTests/fast/dom/domListEnumeration-expected.txt
r31142 r32664 33 33 34 34 [object HTMLFormElement] 35 PASS resultArray.length is 11 335 PASS resultArray.length is 114 36 36 PASS resultArray[0].i is '0' 37 37 PASS resultArray[0].item is document.getElementsByTagName('select')[0] -
trunk/LayoutTests/fast/dom/plugin-attributes-enumeration-expected.txt
r30635 r32664 17 17 hspace 18 18 standby 19 tabIndex20 19 type 21 20 useMap -
trunk/LayoutTests/fast/dom/resources/domListEnumeration.js
r31142 r32664 131 131 var htmlFormElement = document.getElementsByTagName('form')[0]; 132 132 resultArray = iterateList(htmlFormElement); 133 shouldBe("resultArray.length", "11 3");133 shouldBe("resultArray.length", "114"); 134 134 shouldBe("resultArray[0].i", "'0'"); 135 135 shouldBe("resultArray[0].item", "document.getElementsByTagName('select')[0]"); -
trunk/WebCore/ChangeLog
r32660 r32664 1 2008-04-28 Alice Liu <alice.liu@apple.com> 2 3 Reviewed by Darin. 4 5 Fix <rdar://problem/4911289> Add tabindex property to all children 6 of HTMLElement (7138) 7 http://bugs.webkit.org/show_bug.cgi?id=7138 8 9 Test: fast/events/tabindex-focus-blur-all.html 10 11 * WebCore.xcodeproj/project.pbxproj: 12 * bindings/objc/DOMPrivate.h: 13 -DOMHTMLLabelElementPrivate.h and DOMHTMLLegendElementPrivate.h are no 14 longer needed 15 16 * bindings/objc/PublicDOMInterfaces.h: 17 -Moving focus, blur, tabindex to HTMLElement from its descendants. 18 19 * dom/Node.cpp: 20 (WebCore::Node::Node): 21 (WebCore::Node::isFocusable): 22 (WebCore::Node::isKeyboardFocusable): 23 -The concept of being focusable now needs to account for tabindex 24 attribute. 25 26 * dom/Node.h: 27 -Need to use a bit to keep track of whether tabindex was explicitly set 28 to 0 or was just initialized to 0. 29 (WebCore::Node::tabIndex): 30 -Make this virtual so that Anchors and GenericFormElements can determine 31 tabindex without accounting for focusability 32 (WebCore::Node::setTabIndexExplicitly): 33 -Renamed setTabIndex() to setTabIndexExplicitly() so as not to hide 34 behind and/or be confused for HTMLElement::setTabIndex 35 36 * html/HTMLAnchorElement.cpp: 37 * html/HTMLAnchorElement.h: 38 (WebCore::HTMLAnchorElement::tabIndex): 39 * html/HTMLGenericFormElement.cpp: 40 * html/HTMLGenericFormElement.h: 41 (WebCore::HTMLGenericFormElement::tabIndex): 42 -Anchors and form elements are normally focusable, and need to avert the 43 check for focusability in HTMLElement::tabIndex 44 because tabIndex could be queried before a first layout happens. 45 46 * html/HTMLElement.cpp: 47 (WebCore::HTMLElement::parseMappedAttribute): 48 -Function Node::setTabIndex changed to Node::setTabIndexExplicitly 49 (WebCore::HTMLElement::isFocusable): 50 -The concept of being focusable now needs to account for tabindex 51 attribute. 52 (WebCore::HTMLElement::tabIndex): 53 -HTML5 specifies that querying tabindex for elements that aren't 54 focusable shall return -1 55 (WebCore::HTMLElement::setTabIndex): 56 -New default implementation 57 * html/HTMLElement.h: 58 59 * html/HTMLLegendElement.cpp: 60 (WebCore::HTMLLegendElement::focus): 61 -Now with HTML5's enhanced specification of tabindex, legend elements 62 themselves shall focus (if they should), and not the first form element 63 they encapsulate. This matches Firefox behavior. HTMLLabelElements 64 still forward focus to the encapsulated element. This also matches 65 other browsers. 66 67 * html/HTMLAreaElement.cpp: 68 (WebCore::HTMLAreaElement::isFocusable): 69 * html/HTMLAreaElement.h: 70 -HTMLAreaElement isn't subject to the same focusability requirements as 71 its parent, HTMLAnchorElement. Default HTMLElement implementation is 72 desired. 73 74 * html/HTMLFieldSetElement.cpp: 75 (WebCore::HTMLFieldSetElement::isFocusable): 76 * html/HTMLLegendElement.cpp: 77 (WebCore::HTMLLegendElement::isFocusable): 78 * html/HTMLOptGroupElement.cpp: 79 (WebCore::HTMLOptGroupElement::isFocusable): 80 * html/HTMLOptionElement.cpp: 81 (WebCore::HTMLOptionElement::isFocusable): 82 -These elements aren't subject to the same focusability requirements as 83 their parent, HTMLGenericFormElement. Default HTMLElement 84 implementation is desired. 85 86 * html/HTMLAnchorElement.idl: 87 * html/HTMLAreaElement.idl: 88 * html/HTMLButtonElement.idl: 89 * html/HTMLElement.idl: 90 * html/HTMLInputElement.idl: 91 * html/HTMLLabelElement.idl: 92 * html/HTMLLegendElement.idl: 93 * html/HTMLObjectElement.idl: 94 * html/HTMLSelectElement.idl: 95 * html/HTMLTextAreaElement.idl: 96 -Moving tabindex attribute, focus and blur methods from descendants of 97 HTMLElement to HTMLElement 98 1 99 2008-04-28 Dan Bernstein <mitz@apple.com> 2 100 -
trunk/WebCore/WebCore.xcodeproj/project.pbxproj
r32586 r32664 356 356 1CFCEE970AACC40100348750 /* DOMHTMLButtonElementPrivate.h in Copy Generated Headers */ = {isa = PBXBuildFile; fileRef = 1CFCEE8E0AACC3CD00348750 /* DOMHTMLButtonElementPrivate.h */; }; 357 357 1CFCEE980AACC40100348750 /* DOMHTMLImageElementPrivate.h in Copy Generated Headers */ = {isa = PBXBuildFile; fileRef = 1CFCEE8F0AACC3CD00348750 /* DOMHTMLImageElementPrivate.h */; }; 358 1CFCEE990AACC40100348750 /* DOMHTMLLabelElementPrivate.h in Copy Generated Headers */ = {isa = PBXBuildFile; fileRef = 1CFCEE900AACC3CD00348750 /* DOMHTMLLabelElementPrivate.h */; };359 1CFCEE9A0AACC40100348750 /* DOMHTMLLegendElementPrivate.h in Copy Generated Headers */ = {isa = PBXBuildFile; fileRef = 1CFCEE910AACC3CD00348750 /* DOMHTMLLegendElementPrivate.h */; };360 358 1CFCEE9B0AACC40100348750 /* DOMHTMLLinkElementPrivate.h in Copy Generated Headers */ = {isa = PBXBuildFile; fileRef = 1CFCEE920AACC3CD00348750 /* DOMHTMLLinkElementPrivate.h */; }; 361 359 1CFCEE9D0AACC40100348750 /* DOMHTMLStyleElementPrivate.h in Copy Generated Headers */ = {isa = PBXBuildFile; fileRef = 1CFCEE940AACC3CD00348750 /* DOMHTMLStyleElementPrivate.h */; }; … … 4092 4090 85BA4D2B0AA6889F0088052D /* DOMHTMLLIElement.h in Copy Generated Headers */, 4093 4091 85BA4CE70AA686510088052D /* DOMHTMLLabelElement.h in Copy Generated Headers */, 4094 1CFCEE990AACC40100348750 /* DOMHTMLLabelElementPrivate.h in Copy Generated Headers */,4095 4092 85BA4CE80AA686510088052D /* DOMHTMLLegendElement.h in Copy Generated Headers */, 4096 1CFCEE9A0AACC40100348750 /* DOMHTMLLegendElementPrivate.h in Copy Generated Headers */,4097 4093 8575DF860AA6130E00F5DBB5 /* DOMHTMLLinkElement.h in Copy Generated Headers */, 4098 4094 1CFCEE9B0AACC40100348750 /* DOMHTMLLinkElementPrivate.h in Copy Generated Headers */, … … 4812 4808 1CFCEE8E0AACC3CD00348750 /* DOMHTMLButtonElementPrivate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DOMHTMLButtonElementPrivate.h; sourceTree = "<group>"; }; 4813 4809 1CFCEE8F0AACC3CD00348750 /* DOMHTMLImageElementPrivate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DOMHTMLImageElementPrivate.h; sourceTree = "<group>"; }; 4814 1CFCEE900AACC3CD00348750 /* DOMHTMLLabelElementPrivate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DOMHTMLLabelElementPrivate.h; sourceTree = "<group>"; };4815 1CFCEE910AACC3CD00348750 /* DOMHTMLLegendElementPrivate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DOMHTMLLegendElementPrivate.h; sourceTree = "<group>"; };4816 4810 1CFCEE920AACC3CD00348750 /* DOMHTMLLinkElementPrivate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DOMHTMLLinkElementPrivate.h; sourceTree = "<group>"; }; 4817 4811 1CFCEE940AACC3CD00348750 /* DOMHTMLStyleElementPrivate.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DOMHTMLStyleElementPrivate.h; sourceTree = "<group>"; }; … … 9855 9849 85BA4CD90AA6861B0088052D /* DOMHTMLLabelElement.h */, 9856 9850 85BA4CDA0AA6861B0088052D /* DOMHTMLLabelElement.mm */, 9857 1CFCEE900AACC3CD00348750 /* DOMHTMLLabelElementPrivate.h */,9858 9851 85BA4CDB0AA6861B0088052D /* DOMHTMLLegendElement.h */, 9859 9852 85BA4CDC0AA6861B0088052D /* DOMHTMLLegendElement.mm */, 9860 1CFCEE910AACC3CD00348750 /* DOMHTMLLegendElementPrivate.h */,9861 9853 85BA4D030AA688680088052D /* DOMHTMLLIElement.h */, 9862 9854 85BA4D040AA688680088052D /* DOMHTMLLIElement.mm */, -
trunk/WebCore/bindings/objc/DOMPrivate.h
r24771 r32664 48 48 #import <WebCore/DOMHTMLImageElementPrivate.h> 49 49 #import <WebCore/DOMHTMLInputElementPrivate.h> 50 #import <WebCore/DOMHTMLLabelElementPrivate.h>51 #import <WebCore/DOMHTMLLegendElementPrivate.h>52 50 #import <WebCore/DOMHTMLLinkElementPrivate.h> 53 51 #import <WebCore/DOMHTMLOptionsCollectionPrivate.h> -
trunk/WebCore/bindings/objc/PublicDOMInterfaces.h
r29663 r32664 179 179 - (BOOL)hasAttributeNS:(NSString *)namespaceURI :(NSString *)localName; 180 180 - (BOOL)hasAttributeNS:(NSString *)namespaceURI localName:(NSString *)localName; 181 - (void)focus;182 - (void)blur;183 181 - (void)scrollIntoView:(BOOL)alignWithTop; 184 182 - (void)scrollIntoViewIfNeeded:(BOOL)centerIfNeeded; … … 268 266 @property(copy) NSString *rev; 269 267 @property(copy) NSString *shape; 270 @property int tabIndex;271 268 @property(copy) NSString *target; 272 269 @property(copy) NSString *type; 273 270 @property(readonly, copy) NSURL *absoluteLinkURL; 274 - (void)blur;275 - (void)focus;276 271 @end 277 272 … … 297 292 @property BOOL noHref; 298 293 @property(copy) NSString *shape; 299 @property int tabIndex;300 294 @property(copy) NSString *target; 301 295 @property(readonly, copy) NSURL *absoluteLinkURL; … … 331 325 @property BOOL disabled; 332 326 @property(copy) NSString *name; 333 @property int tabIndex;334 327 @property(readonly, copy) NSString *type; 335 328 @property(copy) NSString *value; … … 380 373 @property(readonly) BOOL isContentEditable; 381 374 @property(readonly, copy) NSString *titleDisplayString; 375 @property int tabIndex; 376 - (void)blur; 377 - (void)focus; 382 378 @end 383 379 … … 496 492 @property(copy) NSString *size; 497 493 @property(copy) NSString *src; 498 @property int tabIndex;499 494 @property(copy) NSString *type; 500 495 @property(copy) NSString *useMap; … … 502 497 @property(readonly, copy) NSString *altDisplayString; 503 498 @property(readonly, copy) NSURL *absoluteImageURL; 504 - (void)blur;505 - (void)focus;506 499 - (void)select; 507 500 - (void)click; … … 589 582 @property(copy) NSString *name; 590 583 @property(copy) NSString *standby; 591 @property int tabIndex;592 584 @property(copy) NSString *type; 593 585 @property(copy) NSString *useMap; … … 660 652 @property(copy) NSString *name; 661 653 @property int size; 662 @property int tabIndex;663 654 - (void)add:(DOMHTMLElement *)element :(DOMHTMLElement *)before; 664 655 - (void)add:(DOMHTMLElement *)element before:(DOMHTMLElement *)before; 665 656 - (void)remove:(int)index; 666 - (void)blur;667 - (void)focus;668 657 @end 669 658 … … 762 751 @property BOOL readOnly; 763 752 @property int rows; 764 @property int tabIndex;765 753 @property(readonly, copy) NSString *type; 766 754 @property(copy) NSString *value; 767 - (void)blur;768 - (void)focus;769 755 - (void)select; 770 756 @end -
trunk/WebCore/dom/Node.cpp
r31767 r32664 42 42 #include "Frame.h" 43 43 #include "HTMLNames.h" 44 #include "HTMLNames.h"45 44 #include "Logging.h" 46 45 #include "NameNodeList.h" … … 138 137 m_inActiveChain(false), 139 138 m_inDetach(false), 140 m_inSubtreeMark(false) 139 m_inSubtreeMark(false), 140 m_tabIndexSetExplicitly(false) 141 141 { 142 142 #ifndef NDEBUG … … 390 390 bool Node::isFocusable() const 391 391 { 392 return false;392 return m_tabIndexSetExplicitly; 393 393 } 394 394 395 395 bool Node::isKeyboardFocusable(KeyboardEvent*) const 396 396 { 397 return isFocusable() ;397 return isFocusable() && m_tabIndex >= 0; 398 398 } 399 399 -
trunk/WebCore/dom/Node.h
r31767 r32664 252 252 virtual void setHovered(bool b = true) { m_hovered = b; } 253 253 254 short tabIndex() const { return m_tabIndex; } 255 void setTabIndex(short i) { m_tabIndex = i; } 254 virtual short tabIndex() const { return m_tabIndex; } 256 255 257 256 /** … … 470 469 Node* m_next; 471 470 RenderObject* m_renderer; 471 short m_tabIndex; 472 472 473 473 protected: … … 476 476 477 477 virtual void getSubresourceAttributeStrings(Vector<String>&) const { } 478 void setTabIndexExplicitly(short i) 479 { 480 m_tabIndex = i; 481 m_tabIndexSetExplicitly = true; 482 } 478 483 479 484 OwnPtr<NodeListsNodeData> m_nodeLists; 480 481 short m_tabIndex;482 485 483 486 // make sure we don't use more than 16 bits here -- adding more would increase the size of all Nodes … … 501 504 public: 502 505 bool m_inSubtreeMark : 1; 503 // 1 bit left504 506 505 507 private: 508 bool m_tabIndexSetExplicitly : 1; 509 // no bits left 510 506 511 Element* ancestorElement() const; 507 512 -
trunk/WebCore/html/HTMLAnchorElement.cpp
r31405 r32664 392 392 } 393 393 394 short HTMLAnchorElement::tabIndex() const 395 { 396 return Element::tabIndex(); 397 } 398 394 399 void HTMLAnchorElement::setTabIndex(int tabIndex) 395 400 { -
trunk/WebCore/html/HTMLAnchorElement.h
r30243 r32664 77 77 void setShape(const String&); 78 78 79 short tabIndex() const; 79 80 void setTabIndex(int); 80 81 -
trunk/WebCore/html/HTMLAnchorElement.idl
r29672 r32664 35 35 attribute [ConvertNullToNullString] DOMString rev; 36 36 attribute [ConvertNullToNullString] DOMString shape; 37 attribute long tabIndex;38 37 attribute [ConvertNullToNullString] DOMString target; 39 38 attribute [ConvertNullToNullString] DOMString type; 40 41 void blur();42 void focus();43 39 44 40 // IE Extensions -
trunk/WebCore/html/HTMLAreaElement.cpp
r30243 r32664 214 214 } 215 215 216 bool HTMLAreaElement::isFocusable() const 217 { 218 return HTMLElement::isFocusable(); 219 } 220 216 221 String HTMLAreaElement::target() const 217 222 { -
trunk/WebCore/html/HTMLAreaElement.h
r30243 r32664 67 67 68 68 void setTabIndex(int); 69 bool isFocusable() const; 69 70 70 71 virtual String target() const; -
trunk/WebCore/html/HTMLAreaElement.idl
r29672 r32664 32 32 attribute boolean noHref; 33 33 attribute [ConvertNullToNullString] DOMString shape; 34 attribute long tabIndex;35 34 attribute [ConvertNullToNullString] DOMString target; 36 35 -
trunk/WebCore/html/HTMLButtonElement.idl
r29672 r32664 30 30 attribute boolean disabled; 31 31 attribute [ConvertNullToNullString] DOMString name; 32 attribute long tabIndex;33 32 readonly attribute DOMString type; 34 33 attribute [ConvertNullToNullString] DOMString value; -
trunk/WebCore/html/HTMLElement.cpp
r31435 r32664 146 146 if (indexstring.length()) 147 147 // Clamp tabindex to the range of 'short' to match Firefox's behavior. 148 setTabIndex (max(static_cast<int>(std::numeric_limits<short>::min()), min(indexstring.toInt(), static_cast<int>(std::numeric_limits<short>::max()))));148 setTabIndexExplicitly(max(static_cast<int>(std::numeric_limits<short>::min()), min(indexstring.toInt(), static_cast<int>(std::numeric_limits<short>::max())))); 149 149 } else if (attr->name() == langAttr) { 150 150 // FIXME: Implement … … 526 526 bool HTMLElement::isFocusable() const 527 527 { 528 return isContentEditable() && parent() && !parent()->isContentEditable();528 return Element::isFocusable() || (isContentEditable() && parent() && !parent()->isContentEditable()); 529 529 } 530 530 … … 702 702 { 703 703 setAttribute(classAttr, value); 704 } 705 706 short HTMLElement::tabIndex() const 707 { 708 if (supportsFocus()) 709 return Element::tabIndex(); 710 return -1; 711 } 712 713 void HTMLElement::setTabIndex(int value) 714 { 715 setAttribute(tabindexAttr, String::number(value)); 704 716 } 705 717 -
trunk/WebCore/html/HTMLElement.h
r25754 r32664 60 60 String className() const; 61 61 void setClassName(const String&); 62 short tabIndex() const; 63 void setTabIndex(int); 62 64 63 65 String innerHTML() const; -
trunk/WebCore/html/HTMLElement.idl
r29672 r32664 36 36 attribute [ConvertNullToNullString] DOMString className; 37 37 38 attribute long tabIndex; 39 void blur(); 40 void focus(); 41 38 42 // Extensions 39 43 attribute [ConvertNullToNullString] DOMString innerHTML -
trunk/WebCore/html/HTMLFieldSetElement.cpp
r25754 r32664 51 51 bool HTMLFieldSetElement::isFocusable() const 52 52 { 53 return false;53 return HTMLElement::isFocusable(); 54 54 } 55 55 -
trunk/WebCore/html/HTMLGenericFormElement.cpp
r30112 r32664 206 206 setAttribute(tabindexAttr, String::number(value)); 207 207 } 208 209 short HTMLGenericFormElement::tabIndex() const 210 { 211 return Element::tabIndex(); 212 } 208 213 209 214 bool HTMLGenericFormElement::supportsFocus() const -
trunk/WebCore/html/HTMLGenericFormElement.h
r30112 r32664 90 90 91 91 void setTabIndex(int); 92 short tabIndex() const; 92 93 93 94 void formDestroyed() { m_form = 0; } -
trunk/WebCore/html/HTMLInputElement.idl
r29672 r32664 46 46 #endif 47 47 attribute [ConvertNullToNullString] DOMString src; 48 attribute long tabIndex;49 48 attribute [ConvertNullToNullString] DOMString type; // readonly dropped as part of DOM level 2 50 49 attribute [ConvertNullToNullString] DOMString useMap; 51 50 attribute [ConvertNullToNullString] DOMString value; 52 51 53 void blur();54 void focus();55 52 void select(); 56 53 void click(); -
trunk/WebCore/html/HTMLLabelElement.idl
r29672 r32664 29 29 attribute [ConvertNullToNullString] DOMString accessKey; 30 30 attribute [ConvertNullToNullString] DOMString htmlFor; 31 32 void focus();33 31 }; 34 32 -
trunk/WebCore/html/HTMLLegendElement.cpp
r25754 r32664 46 46 bool HTMLLegendElement::isFocusable() const 47 47 { 48 return false;48 return HTMLElement::isFocusable(); 49 49 } 50 50 … … 108 108 void HTMLLegendElement::focus(bool) 109 109 { 110 if (isFocusable()) 111 Element::focus(); 112 110 113 // to match other browsers, never restore previous selection 111 114 if (Element *element = formElement()) -
trunk/WebCore/html/HTMLLegendElement.idl
r29672 r32664 29 29 attribute [ConvertNullToNullString] DOMString accessKey; 30 30 attribute [ConvertNullToNullString] DOMString align; 31 32 void focus();33 31 }; 34 32 -
trunk/WebCore/html/HTMLObjectElement.idl
r29672 r32664 43 43 attribute [ConvertNullToNullString] DOMString name; 44 44 attribute [ConvertNullToNullString] DOMString standby; 45 attribute long tabIndex;46 45 attribute [ConvertNullToNullString] DOMString type; 47 46 attribute [ConvertNullToNullString] DOMString useMap; -
trunk/WebCore/html/HTMLOptGroupElement.cpp
r30633 r32664 44 44 bool HTMLOptGroupElement::isFocusable() const 45 45 { 46 return false;46 return HTMLElement::isFocusable(); 47 47 } 48 48 -
trunk/WebCore/html/HTMLOptionElement.cpp
r30633 r32664 76 76 bool HTMLOptionElement::isFocusable() const 77 77 { 78 return false;78 return HTMLElement::isFocusable(); 79 79 } 80 80 -
trunk/WebCore/html/HTMLSelectElement.idl
r29672 r32664 50 50 attribute [ConvertNullToNullString] DOMString name; 51 51 attribute long size; 52 attribute long tabIndex;53 52 54 53 [OldStyleObjC] void add(in HTMLElement element, … … 62 61 void remove(in long index); 63 62 #endif 64 void blur();65 void focus();66 63 67 64 // These methods are not in DOM Level 2 IDL, but are mentioned in the standard: -
trunk/WebCore/html/HTMLTextAreaElement.idl
r29672 r32664 34 34 attribute boolean readOnly; 35 35 attribute long rows; 36 attribute long tabIndex;37 36 readonly attribute DOMString type; 38 37 attribute [ConvertNullToNullString] DOMString value; 39 38 40 void blur();41 void focus();42 39 void select(); 43 40 -
trunk/WebKit/mac/ChangeLog
r32652 r32664 1 2008-04-28 Alice Liu <alice.liu@apple.com> 2 3 Reviewed by Darin. 4 5 Fix <rdar://problem/4911289> Add tabindex property to all children 6 of HTMLElement (7138) 7 http://bugs.webkit.org/show_bug.cgi?id=7138 8 9 * MigrateHeaders.make: 10 Removing DOMHTMLLabelElementPrivate.h and DOMHTMLLegendElementPrivate.h 11 because now that focus() has been moved to DOMHTMLElement.h, these 12 files are no longer needed. 13 1 14 2008-04-25 Alexey Proskuryakov <ap@webkit.org> 2 15 -
trunk/WebKit/mac/MigrateHeaders.make
r31321 r32664 125 125 $(PUBLIC_HEADERS_DIR)/DOMHTMLLIElement.h \ 126 126 $(PUBLIC_HEADERS_DIR)/DOMHTMLLabelElement.h \ 127 $(PRIVATE_HEADERS_DIR)/DOMHTMLLabelElementPrivate.h \128 127 $(PUBLIC_HEADERS_DIR)/DOMHTMLLegendElement.h \ 129 $(PRIVATE_HEADERS_DIR)/DOMHTMLLegendElementPrivate.h \130 128 $(PUBLIC_HEADERS_DIR)/DOMHTMLLinkElement.h \ 131 129 $(PRIVATE_HEADERS_DIR)/DOMHTMLLinkElementPrivate.h \
Note: See TracChangeset
for help on using the changeset viewer.