Changeset 33517 in webkit


Ignore:
Timestamp:
May 16, 2008 5:06:56 AM (16 years ago)
Author:
oliver@apple.com
Message:

Bug 19098: SquirrelFish: Ref'd temporaries can be clobbered
<​https://bugs.webkit.org/show_bug.cgi?id=19098>

Patch from Cameron Zwarich
Reviewed by Oliver

When doing code generation for a statement list, increase the reference
count on a register that might eventually be returned, so that it doesn't
get clobbered by a request for a new temporary.

Location:
branches/squirrelfish
Files:
3 added
3 edited

Legend:

Unmodified
Added
Removed

  • branches/squirrelfish/JavaScriptCore/ChangeLog

    r33516 r33517  
     12008-05-16  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
     2
     3        Reviewed by Oliver Hunt.
     4
     5        Bug 19098: SquirrelFish: Ref'd temporaries can be clobbered
     6        <https://bugs.webkit.org/show_bug.cgi?id=19098>
     7
     8        When doing code generation for a statement list, increase the reference
     9        count on a register that might eventually be returned, so that it doesn't
     10        get clobbered by a request for a new temporary.
     11
     12        * kjs/nodes.cpp:
     13        (KJS::statementListEmitCode):
     14
    1152008-05-16  Maciej Stachowiak  <mjs@apple.com>
    216

  • branches/squirrelfish/JavaScriptCore/kjs/nodes.cpp

    r33484 r33517  
    46744674static inline RegisterID* statementListEmitCode(StatementVector& statements, CodeGenerator& generator, RegisterID* dst = 0)
    46754675{
    4676     RegisterID* r0 = dst;
     4676    RefPtr<RegisterID> r0 = dst;
    46774677
    46784678    StatementVector::iterator end = statements.end();
    … …  
    46844684    }
    46854685   
    4686     return r0;
     4686    return r0.get();
    46874687}
    46884688

  • branches/squirrelfish/LayoutTests/ChangeLog

    r33516 r33517  
     12008-05-16  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
     2
     3        Reviewed by Oliver Hunt.
     4
     5        Add tests for:
     6
     7        Bug 19098: SquirrelFish: Ref'd temporaries can be clobbered
     8        <https://bugs.webkit.org/show_bug.cgi?id=19098>
     9
     10        * fast/js/resources/statement-list-register-crash.js: Added.
     11        * fast/js/statement-list-register-crash-expected.txt: Added.
     12        * fast/js/statement-list-register-crash.html: Added.
     13
    1142008-05-16  Maciej Stachowiak  <mjs@apple.com>
    215
Note: See TracChangeset for help on using the changeset viewer.