Changeset 34734 in webkit

Timestamp:

Jun 22, 2008 6:20:07 PM (16 years ago)

Author:

mrowe@apple.com

Message:

2008-06-22 Robert Blaut <​webkit@blaut.biz>

Reviewed by Darin Adler.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=17421
Bug 17421: Lack of end tag for SELECT element causes the rest of page to not be rendered

Test: fast/parser/input-textarea-inside-select-element.html

• html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/parser/input-textarea-inside-select-element-expected.txt (added)
• LayoutTests/fast/parser/input-textarea-inside-select-element.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/html/HTMLParser.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2008-06-22  Robert Blaut  <webkit@blaut.biz>
+
+        Reviewed by Darin Adler.
+
+        Test for https://bugs.webkit.org/show_bug.cgi?id=17421
+        Bug 17421: Lack of end tag for SELECT element causes the rest of page to not be rendered
+
+        * fast/parser/input-textarea-inside-select-element-expected.txt: Added.
+        * fast/parser/input-textarea-inside-select-element.html: Added.
+
 2008-06-22  Robert Blaut  <webkit@blaut.biz>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-06-22  Robert Blaut  <webkit@blaut.biz>
+
+        Reviewed by Darin Adler.
+
+        Fix for https://bugs.webkit.org/show_bug.cgi?id=17421
+        Bug 17421: Lack of end tag for SELECT element causes the rest of page to not be rendered
+
+        Test: fast/parser/input-textarea-inside-select-element.html
+
+        * html/HTMLParser.cpp:
+        (WebCore::HTMLParser::handleError):
+
 2008-06-22  David Krause  <david.krause@gmail.com>
 

trunk/WebCore/html/HTMLParser.cpp

@@ -613 +613 @@
                 // IE treats a nested select as </select>. Let's do the same
                 popBlock(localName);
+            }
+        } else if (h->hasLocalName(selectTag)) {
+            if (localName == inputTag || localName == textareaTag) {
+                reportError(MisplacedContentRetryError, &localName, &currentTagName);
+                popBlock(currentTagName);
+                handled = true;
             }
         } else if (h->hasLocalName(colgroupTag)) {