Changeset 34758 in webkit


Ignore:
Timestamp:
Jun 24, 2008 2:38:40 AM (16 years ago)
Author:
cwzwarich@webkit.org
Message:

2008-06-24 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Bug 19730: REGRESSION (r34497): Text in alerts in "Leisure suit Larry" is not wrapped
<​https://bugs.webkit.org/show_bug.cgi?id=19730>

Do not convert the pair (less, jtrue) to jless when jtrue is a jump
target. An example of this is when the condition of a while loop is a
LogicalOrNode.

JavaScriptCore:

  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitLabel):

LayoutTests:

  • fast/js/codegen-loops-logical-nodes-expected.txt: Added.
  • fast/js/codegen-loops-logical-nodes.html: Added.
  • fast/js/resources/codegen-loops-logical-nodes.js: Added.
Location:
trunk
Files:
3 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/JavaScriptCore/ChangeLog

    r34757 r34758  
     12008-06-24  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
     2
     3        Reviewed by Oliver.
     4
     5        Bug 19730: REGRESSION (r34497): Text in alerts in "Leisure suit Larry" is not wrapped
     6        <https://bugs.webkit.org/show_bug.cgi?id=19730>
     7
     8        Do not convert the pair (less, jtrue) to jless when jtrue is a jump
     9        target. An example of this is when the condition of a while loop is a
     10        LogicalOrNode.
     11
     12        * VM/CodeGenerator.cpp:
     13        (KJS::CodeGenerator::emitLabel):
     14
    1152008-06-20  Ariya Hidayat  <ariya.hidayat@trolltech.com>
    216

  • trunk/JavaScriptCore/VM/CodeGenerator.cpp

    r34684 r34758  
    391391{
    392392    l0->setLocation(instructions().size());
     393   
     394    // This disables peephole optimizations when an instruction is a jump target
     395    m_lastOpcodeID = op_end;
     396   
    393397    return l0;
    394398}

  • trunk/LayoutTests/ChangeLog

    r34751 r34758  
     12008-06-24  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
     2
     3        Reviewed by Oliver.
     4
     5        Tests for:
     6
     7        Bug 19730: REGRESSION (r34497): Text in alerts in "Leisure suit Larry" is not wrapped
     8        <https://bugs.webkit.org/show_bug.cgi?id=19730>
     9
     10        * fast/js/codegen-loops-logical-nodes-expected.txt: Added.
     11        * fast/js/codegen-loops-logical-nodes.html: Added.
     12        * fast/js/resources/codegen-loops-logical-nodes.js: Added.
     13
    1142008-06-23  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
    215
Note: See TracChangeset for help on using the changeset viewer.