Changeset 34764 in webkit

Timestamp:

Jun 24, 2008 3:58:32 AM (16 years ago)

Author:

Simon Hausmann

Message:

2008-06-24 Jonathon Jongsma <​jonathon.jongsma@collabora.co.uk>

Reviewed by Simon.

​https://bugs.webkit.org/show_bug.cgi?id=18459

Clean up and remove unused platform shadow code.

Minor edits by Simon, removed unused TextShadow struct.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/qt/GraphicsContextQt.cpp (modified) (3 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-06-24  Jonathon Jongsma  <jonathon.jongsma@collabora.co.uk>
+
+        Reviewed by Simon.
+
+        https://bugs.webkit.org/show_bug.cgi?id=18459
+
+        Clean up and remove unused platform shadow code.
+
+        Minor edits by Simon, removed unused TextShadow struct.
+
+        * platform/graphics/qt/GraphicsContextQt.cpp:
+        (WebCore::GraphicsContext::setPlatformShadow):
+        (WebCore::GraphicsContext::clearPlatformShadow): Qt doesn't support a
+        platform shadow, so just make these functions empty.  The shadows are
+        drawn manually in function like drawLine(), etc.
+
 2008-06-24  Jonathon Jongsma  <jonathon.jongsma@collabora.co.uk>
 

trunk/WebCore/platform/graphics/qt/GraphicsContextQt.cpp

@@ -180 +180 @@
 };
 
-struct TextShadow
-{
-    TextShadow()
-        : x(0)
-        , y(0)
-        , blur(0)
-    {
-    }
-
-    bool isNull() { return !x && !y && !blur; }
-
-    int x;
-    int y;
-    int blur;
-
-    Color color;
-};
-
 class GraphicsContextPlatformPrivate
 {
@@ -219 +201 @@
     QStack<TransparencyLayer *> layers;
     QPainter* redirect;
-
-    TextShadow shadow;
 
     // Only used by SVG for now.
@@ -650 +630 @@
 void GraphicsContext::setPlatformShadow(const IntSize& pos, int blur, const Color &color)
 {
-    if (paintingDisabled())
-        return;
-
-    m_data->shadow.x = pos.width();
-    m_data->shadow.y = pos.height();
-    m_data->shadow.blur = blur;
-    m_data->shadow.color = color;
+    // Qt doesn't support shadows natively, they are drawn manually in the draw*
+    // functions
 }
 
 void GraphicsContext::clearPlatformShadow()
 {
-    if (paintingDisabled())
-        return;
-
-    m_data->shadow = TextShadow();
+    // Qt doesn't support shadows natively, they are drawn manually in the draw*
+    // functions
 }