Changeset 35785 in webkit

Timestamp:

Aug 15, 2008 10:02:44 AM (16 years ago)

Author:

timothy@apple.com

Message:

Cmd-F on Mac or Ctrl-F on other platforms now focus the search field.

Platform distinction and modifier key matching adjusted
by Daniel Jalkut <​jalkut@red-sweater.com>

Bug 16313: text search (find) keybindings should work in the Web Inspector
​https://bugs.webkit.org/show_bug.cgi?id=16313

Reviewed by Tim Hatcher.

• page/inspector/inspector.js: Added a case for the F key

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/inspector/inspector.js (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-08-15  Anthony Ricaud  <rik24d@gmail.com>
+
+        Cmd-F on Mac or Ctrl-F on other platforms now focus the search field.
+
+        Platform distinction and modifier key matching adjusted
+        by Daniel Jalkut <jalkut@red-sweater.com>
+
+        Bug 16313: text search (find) keybindings should work in the Web Inspector
+        https://bugs.webkit.org/show_bug.cgi?id=16313
+
+        Reviewed by Tim Hatcher.
+
+        * page/inspector/inspector.js: Added a case for the F key
+
 2008-08-15  Keishi Hattori  <casey.hattori@gmail.com>
 

trunk/WebCore/page/inspector/inspector.js

@@ -463 +463 @@
                 this.console.visible = !this.console.visible;
                 event.preventDefault();
+                break;
+            case "U+0046": // F key
+                var isMac = InspectorController.platform().indexOf("mac-") === 0;
+                var isFindKey;
+                // We want cmd-F for Mac, or ctrl-F for non-Mac
+                if (isMac)
+                    isFindKey = event.metaKey && !event.ctrlKey && !event.altKey && !event.shiftKey;
+                else
+                    isFindKey = event.ctrlKey && !event.metaKey && !event.altKey && !event.shiftKey;
+
+                if (isFindKey) {
+                    document.getElementById("search").focus();
+                    event.preventDefault();
+                }
                 break;
         }