Changeset 35884 in webkit

Timestamp:

Aug 21, 2008 7:07:54 PM (16 years ago)

Author:

mrowe@apple.com

Message:

2008-08-21 Kalle Vahlman <​kalle.vahlman@movial.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=19171
[GTK] Crash on some pages due to a plugin

Fix handling of badly formatted and empty plugin mime descriptions

• plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::fetchInfo):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• plugins/gtk/PluginPackageGtk.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-08-21  Kalle Vahlman  <kalle.vahlman@movial.com>
+
+        Reviewed by Darin Adler.
+
+        https://bugs.webkit.org/show_bug.cgi?id=19171
+        [GTK] Crash on some pages due to a plugin
+
+        Fix handling of badly formatted and empty plugin mime descriptions
+
+        * plugins/gtk/PluginPackageGtk.cpp:
+        (WebCore::PluginPackage::fetchInfo):
+
 2008-08-21  Kevin Watters  <kevinwatters@gmail.com>
 

trunk/WebCore/plugins/gtk/PluginPackageGtk.cpp

@@ -75 +75 @@
     for (int i = 0; mimeDescs[i] && mimeDescs[i][0]; i++) {
         gchar** mimeData = g_strsplit(mimeDescs[i], ":", 3);
+        if (g_strv_length(mimeData) < 3) {
+            g_strfreev(mimeData);
+            continue;
+        }
 
         String description = String::fromUTF8(mimeData[2]);