Changeset 35891 in webkit

Timestamp:

Aug 22, 2008 11:39:42 AM (16 years ago)

Author:

timothy@apple.com

Message:

Fixes a bug where while editing in the Inspector the
sidebar scroll position would jump to the top.

​https://bugs.webkit.org/show_bug.cgi?id=20484

Reviewed by Darin Adler.

• page/inspector/treeoutline.js: (TreeOutline._removeChildren): Remove the offsetTop call that was forcing a layout, since layout causes scroll positions to be clamped to the new scrollHeight/Width. Layout will happen normally when needed.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/inspector/treeoutline.js (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-08-22  Timothy Hatcher  <timothy@apple.com>
+
+        Fixes a bug where while editing in the Inspector the
+        sidebar scroll position would jump to the top.
+
+        https://bugs.webkit.org/show_bug.cgi?id=20484
+
+        Reviewed by Darin Adler.
+
+        * page/inspector/treeoutline.js:
+        (TreeOutline._removeChildren): Remove the offsetTop call that
+        was forcing a layout, since layout causes scroll positions
+        to be clamped to the new scrollHeight/Width. Layout will happen
+        normally when needed.
+
 2008-08-22  Kevin Ollivier  <kevino@theolliviers.com>
 

trunk/WebCore/page/inspector/treeoutline.js

@@ -185 +185 @@
 
     this.children = [];
-
-    if (this._childrenListNode)
-        this._childrenListNode.offsetTop; // force layout
 }