Changeset 36620 in webkit


Ignore:
Timestamp:
Sep 18, 2008 1:09:41 PM (16 years ago)
Author:
hyatt@apple.com
Message:

2008-09-18 David Hyatt <hyatt@apple.com>

Make invalidate() on Widget non-virtual and make it just call
invalidateRect() on the boundsGeometry() of the Widget.

Reviewed by Dan Bernstein

  • platform/Widget.h: (WebCore::Widget::boundsGeometry): (WebCore::Widget::invalidate):
  • platform/gtk/WidgetGtk.cpp:
  • platform/mac/WidgetMac.mm:
  • platform/qt/WidgetQt.cpp:
  • platform/win/WidgetWin.cpp:
  • platform/wx/WidgetWx.cpp:
Location:
trunk/WebCore
Files:
8 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r36619 r36620  
     12008-09-18  David Hyatt  <hyatt@apple.com>
     2
     3        Make invalidate() on Widget non-virtual and make it just call
     4        invalidateRect() on the boundsGeometry() of the Widget.
     5
     6        Reviewed by Dan Bernstein
     7
     8        * platform/Widget.h:
     9        (WebCore::Widget::boundsGeometry):
     10        (WebCore::Widget::invalidate):
     11        * platform/gtk/WidgetGtk.cpp:
     12        * platform/mac/WidgetMac.mm:
     13        * platform/qt/WidgetQt.cpp:
     14        * platform/win/WidgetWin.cpp:
     15        * platform/wx/WidgetWx.cpp:
     16
    1172008-09-18  Sam Weinig  <sam@webkit.org>
    218
  • trunk/WebCore/WebCore.base.exp

    r36602 r36620  
    533533__ZN7WebCore6StringC1EPKcj
    534534__ZN7WebCore6StringC1ERKN3JSC7UStringE
    535 __ZN7WebCore6Widget10invalidateEv
    536535__ZN7WebCore6Widget14invalidateRectERKNS_7IntRectE
    537536__ZN7WebCore6Widget16removeFromParentEv
  • trunk/WebCore/platform/Widget.h

    r36601 r36620  
    119119    virtual void setFrameGeometry(const IntRect&);
    120120    virtual IntRect frameGeometry() const;
     121    IntRect boundsGeometry() const { return IntRect(0, 0, width(),  height()); }
    121122
    122123    void resize(int w, int h) { setFrameGeometry(IntRect(x(), y(), w, h)); }
     
    126127
    127128    virtual void paint(GraphicsContext*, const IntRect&);
    128     virtual void invalidate();
     129    void invalidate() { invalidateRect(boundsGeometry()); }
    129130    virtual void invalidateRect(const IntRect&);
    130131
  • trunk/WebCore/platform/gtk/WidgetGtk.cpp

    r36601 r36620  
    177177}
    178178
    179 void Widget::invalidate()
    180 {
    181     invalidateRect(IntRect(0, 0, width(), height()));
    182 }
    183 
    184179void Widget::invalidateRect(const IntRect& rect)
    185180{
  • trunk/WebCore/platform/mac/WidgetMac.mm

    r36601 r36620  
    236236}
    237237
    238 void Widget::invalidate()
    239 {
    240     BEGIN_BLOCK_OBJC_EXCEPTIONS;
    241     [platformWidget() setNeedsDisplay: YES];
    242     END_BLOCK_OBJC_EXCEPTIONS;
    243 }
    244 
    245238void Widget::invalidateRect(const IntRect& r)
    246239{
  • trunk/WebCore/platform/qt/WidgetQt.cpp

    r36601 r36620  
    151151}
    152152
    153 void Widget::invalidate()
    154 {
    155     invalidateRect(IntRect(0, 0, width(), height()));
    156 }
    157 
    158153void Widget::invalidateRect(const IntRect& r)
    159154{
  • trunk/WebCore/platform/win/WidgetWin.cpp

    r36601 r36620  
    162162}
    163163
    164 void Widget::invalidate()
    165 {
    166     invalidateRect(IntRect(0, 0, width(), height()));
    167 }
    168 
    169164void Widget::invalidateRect(const IntRect& r)
    170165{
  • trunk/WebCore/platform/wx/WidgetWx.cpp

    r36601 r36620  
    9898}
    9999
    100 void Widget::invalidate()
    101 {
    102     if (platformWidget())
    103         platformWidget()->Refresh();
    104 }
    105 
    106100void Widget::invalidateRect(const IntRect& r)
    107101{
Note: See TracChangeset for help on using the changeset viewer.