Changeset 36847 in webkit

Timestamp:

Sep 24, 2008 1:11:35 AM (16 years ago)

Author:

mjs@apple.com

Message:

2008-09-24 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver Hunt.

• inline PropertyMap::getOffset to speed up polymorphic lookups

~1.5% speedup on v8 benchmark
no effect on SunSpider

• JavaScriptCore.exp:
• kjs/PropertyMap.cpp:
• kjs/PropertyMap.h: (JSC::PropertyMap::getOffset):

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• JavaScriptCore.exp (modified) (1 diff)
• kjs/PropertyMap.cpp (modified) (3 diffs)
• kjs/PropertyMap.h (modified) (3 diffs)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2008-09-24  Maciej Stachowiak  <mjs@apple.com>
+
+        Reviewed by Oliver Hunt.
+        
+        - inline PropertyMap::getOffset to speed up polymorphic lookups
+        
+        ~1.5% speedup on v8 benchmark
+        no effect on SunSpider
+
+        * JavaScriptCore.exp:
+        * kjs/PropertyMap.cpp:
+        * kjs/PropertyMap.h:
+        (JSC::PropertyMap::getOffset):
+
 2008-09-24  Jan Michael Alonzo  <jmalonzo@webkit.org>
 

trunk/JavaScriptCore/JavaScriptCore.exp

@@ -110 +110 @@
 __ZN3JSC11ProgramNode6createEPNS_12JSGlobalDataEPNS_14SourceElementsEPN3WTF6VectorISt4pairINS_10IdentifierEjELm16EEEPNS6_INS5_6RefPtrINS_12FuncDeclNodeEEELm16EEEPNS_14SourceProviderEbbi
 __ZN3JSC11PropertyMap3putERKNS_10IdentifierEPNS_7JSValueEjbPNS_8JSObjectERNS_15PutPropertySlotERPS5_
-__ZN3JSC11PropertyMap9getOffsetERKNS_10IdentifierE
 __ZN3JSC11PropertyMap9getOffsetERKNS_10IdentifierERj
 __ZN3JSC11PropertyMapD1Ev

trunk/JavaScriptCore/kjs/PropertyMap.cpp

@@ -36 +36 @@
 #ifndef NDEBUG
 #define DO_PROPERTYMAP_CONSTENCY_CHECK 0
-#define DUMP_PROPERTYMAP_STATS 0
 #else
 #define DO_PROPERTYMAP_CONSTENCY_CHECK 0
-#define DUMP_PROPERTYMAP_STATS 0
 #endif
 
@@ -76 +74 @@
 #endif
 
-static const unsigned emptyEntryIndex = 0;
 static const unsigned deletedSentinelIndex = 1;
 
@@ -271 +268 @@
 }
 
-size_t PropertyMap::getOffset(const Identifier& propertyName)
-{
-    ASSERT(!propertyName.isNull());
-
-    if (!m_table)
-        return WTF::notFound;
-
-    UString::Rep* rep = propertyName._ustring.rep();
-
-    unsigned i = rep->computedHash();
-
-#if DUMP_PROPERTYMAP_STATS
-    ++numProbes;
-#endif
-
-    unsigned entryIndex = m_table->entryIndices[i & m_table->sizeMask];
-    if (entryIndex == emptyEntryIndex)
-        return WTF::notFound;
-
-    if (rep == m_table->entries()[entryIndex - 1].key)
-        return entryIndex - 2;
-
-#if DUMP_PROPERTYMAP_STATS
-    ++numCollisions;
-#endif
-
-    unsigned k = 1 | doubleHash(rep->computedHash());
-
-    while (1) {
-        i += k;
-
-#if DUMP_PROPERTYMAP_STATS
-        ++numRehashes;
-#endif
-
-        entryIndex = m_table->entryIndices[i & m_table->sizeMask];
-        if (entryIndex == emptyEntryIndex)
-            return WTF::notFound;
-
-        if (rep == m_table->entries()[entryIndex - 1].key)
-            return entryIndex - 2;
-    }
-}
-
 size_t PropertyMap::getOffset(const Identifier& propertyName, unsigned& attributes)
 {

trunk/JavaScriptCore/kjs/PropertyMap.h

@@ -26 +26 @@
 #include <wtf/OwnArrayPtr.h>
 #include <wtf/NotFound.h>
+
+#ifndef NDEBUG
+#define DUMP_PROPERTYMAP_STATS 0
+#else
+#define DUMP_PROPERTYMAP_STATS 0
+#endif
 
 namespace JSC {
@@ -103 +109 @@
         unsigned storageSize() const { return m_table ? m_table->keyCount + m_table->deletedSentinelCount : 0; }
 
+        static const unsigned emptyEntryIndex = 0;
+
     private:
         typedef PropertyMapEntry Entry;
@@ -126 +134 @@
     }
 
+    inline size_t PropertyMap::getOffset(const Identifier& propertyName)
+    {
+        ASSERT(!propertyName.isNull());
+
+        if (!m_table)
+            return WTF::notFound;
+
+        UString::Rep* rep = propertyName._ustring.rep();
+
+        unsigned i = rep->computedHash();
+
+#if DUMP_PROPERTYMAP_STATS
+        ++numProbes;
+#endif
+
+        unsigned entryIndex = m_table->entryIndices[i & m_table->sizeMask];
+        if (entryIndex == emptyEntryIndex)
+            return WTF::notFound;
+
+        if (rep == m_table->entries()[entryIndex - 1].key)
+            return entryIndex - 2;
+
+#if DUMP_PROPERTYMAP_STATS
+        ++numCollisions;
+#endif
+
+        unsigned k = 1 | WTF::doubleHash(rep->computedHash());
+
+        while (1) {
+            i += k;
+
+#if DUMP_PROPERTYMAP_STATS
+            ++numRehashes;
+#endif
+
+            entryIndex = m_table->entryIndices[i & m_table->sizeMask];
+            if (entryIndex == emptyEntryIndex)
+                return WTF::notFound;
+
+            if (rep == m_table->entries()[entryIndex - 1].key)
+                return entryIndex - 2;
+        }
+    }
+
 } // namespace JSC