Changeset 36890 in webkit


Ignore:
Timestamp:
Sep 25, 2008 1:57:31 AM (16 years ago)
Author:
dsmith@webkit.org
Message:

WebCore:

2008-09-25 David Smith <​catfish.man@gmail.com>

Reviewed by Eric Seidel


fix ​https://bugs.webkit.org/show_bug.cgi?id=21091
Regression: querySelector matches tag names case sensitively


Tests: fast/dom/SelectorAPI/caseTag.html

fast/dom/SelectorAPI/caseTagX.xhtml

  • css/CSSParser.cpp: (WebCore::CSSParser::parseSelector): Add a Document argument, since tag case sensitivity is different for HTML documents
  • css/CSSParser.h:
  • dom/Node.cpp: (WebCore::Node::querySelector): (WebCore::Node::querySelectorAll):

LayoutTests:

2008-09-25 David Smith <​catfish.man@gmail.com>

Reviewed by Eric Seidel


Tests for ​https://bugs.webkit.org/show_bug.cgi?id=21091
Regression: querySelector matches tag names case sensitively

  • ChangeLog:
  • fast/dom/SelectorAPI/caseTag-expected.txt: Added.
  • fast/dom/SelectorAPI/caseTag.html: Added.
  • fast/dom/SelectorAPI/caseTagX-expected.txt: Added.
  • fast/dom/SelectorAPI/caseTagX.xhtml: Added.
Location:
trunk
Files:
4 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r36875 r36890  
     12008-09-25  David Smith  <catfish.man@gmail.com>
     2
     3        Reviewed by Eric Seidel
     4       
     5        Tests for https://bugs.webkit.org/show_bug.cgi?id=21091
     6        Regression: querySelector matches tag names case sensitively
     7
     8        * ChangeLog:
     9        * fast/dom/SelectorAPI/caseTag-expected.txt: Added.
     10        * fast/dom/SelectorAPI/caseTag.html: Added.
     11        * fast/dom/SelectorAPI/caseTagX-expected.txt: Added.
     12        * fast/dom/SelectorAPI/caseTagX.xhtml: Added.
     13
    1142008-09-24  Sam Weinig  <sam@webkit.org>
    215

  • trunk/WebCore/ChangeLog

    r36886 r36890  
     12008-09-25  David Smith  <catfish.man@gmail.com>
     2
     3        Reviewed by Eric Seidel
     4       
     5        fix https://bugs.webkit.org/show_bug.cgi?id=21091
     6        Regression: querySelector matches tag names case sensitively
     7       
     8        Tests: fast/dom/SelectorAPI/caseTag.html
     9               fast/dom/SelectorAPI/caseTagX.xhtml
     10
     11        * css/CSSParser.cpp:
     12        (WebCore::CSSParser::parseSelector): Add a Document argument, since tag case sensitivity is different for HTML documents
     13        * css/CSSParser.h:
     14        * dom/Node.cpp:
     15        (WebCore::Node::querySelector):
     16        (WebCore::Node::querySelectorAll):
     17
    1182008-09-24  David Hyatt  <hyatt@apple.com>
    219

  • trunk/WebCore/css/CSSParser.cpp

    r36855 r36890  
    306306}
    307307
    308 std::auto_ptr<CSSSelector> CSSParser::parseSelector(const String& string)
    309 {
    310     RefPtr<CSSStyleSheet> dummyStyleSheet = CSSStyleSheet::create();
     308std::auto_ptr<CSSSelector> CSSParser::parseSelector(const String& string, Document* doc)
     309{   
     310    RefPtr<CSSStyleSheet> dummyStyleSheet = CSSStyleSheet::create(doc);
    311311
    312312    m_styleSheet = dummyStyleSheet.get();

  • trunk/WebCore/css/CSSParser.h

    r36485 r36890  
    118118        PassRefPtr<CSSPrimitiveValue> parseColor(CSSParserValue* = 0);
    119119        bool parseColorFromValue(CSSParserValue*, RGBA32&, bool = false);
    120         std::auto_ptr<CSSSelector> parseSelector(const String&);
     120        std::auto_ptr<CSSSelector> parseSelector(const String&, Document* doc = 0);
    121121
    122122        static bool parseColor(const String&, RGBA32& rgb, bool strict);

  • trunk/WebCore/dom/Node.cpp

    r36662 r36890  
    13461346    }
    13471347
    1348     std::auto_ptr<CSSSelector> querySelector = p.parseSelector(selectors);
     1348    std::auto_ptr<CSSSelector> querySelector = p.parseSelector(selectors, document());
    13491349    if (!querySelector.get()) {
    13501350        ec = SYNTAX_ERR;
    … …  
    14061406    }
    14071407
    1408     std::auto_ptr<CSSSelector> querySelector = p.parseSelector(selectors);
     1408    std::auto_ptr<CSSSelector> querySelector = p.parseSelector(selectors, document());
    14091409
    14101410    if (!querySelector.get()) {
Note: See TracChangeset for help on using the changeset viewer.