Changeset 37038 in webkit
- Timestamp:
- Sep 28, 2008 6:23:51 AM (16 years ago)
- Location:
- trunk
- Files:
-
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r37009 r37038 1 2008-09-28 Alexey Proskuryakov <ap@webkit.org> 2 3 Reviewed by Eric Seidel. 4 5 https://bugs.webkit.org/show_bug.cgi?id=20366 6 Reproducible test failure for editing/undo/undo-iframe-location-change.html 7 8 This does not fix the problem, but makes the test more predictable by using iframe onload. 9 Also, makes the test runnable in browser. Turns out that the test reliably fails there too, 10 even without any special steps needed in DRT. 11 12 * editing/undo/undo-iframe-location-change-expected.txt: 13 * editing/undo/undo-iframe-location-change.html: 14 15 * ChangeLog-2007-10-14: Added bug URLs for a patch that included this test. 16 1 17 2008-09-27 Dan Bernstein <mitz@apple.com> 2 18 -
trunk/LayoutTests/ChangeLog-2007-10-14
r36097 r37038 57146 57146 Reviewed by mjs 57147 57147 57148 <http://tinymce.moxiecode.com/example_full.php?example=true>57149 TinyMCE: Undo still enabled after a location change, crashes if performed57148 https://bugs.webkit.org/show_bug.cgi?id=7150 57149 <rdar://4433765> TinyMCE: Undo still enabled after a location change, crashes if performed 57150 57150 57151 57151 * editing/undo/undo-iframe-location-change-expected.txt: Added. -
trunk/LayoutTests/editing/undo/undo-iframe-location-change-expected.txt
r30635 r37038 1 EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of BODY > HTML > #document to 1 of BODY > HTML > #document2 EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification3 EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 0 of BODY > HTML > #document to 0 of BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE4 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification5 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of BODY > HTML > #document to 0 of BODY > HTML > #document toDOMRange:range from 1 of #text > BODY > HTML > #document to 1 of #text > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE6 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification7 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification8 1 9 2 Success -
trunk/LayoutTests/editing/undo/undo-iframe-location-change.html
r17562 r37038 1 <script>2 if (window.layoutTestController)3 layoutTestController.dumpEditingCallbacks();4 </script>5 6 1 <script src="../editing.js"></script> 7 <iframe name="iframe" src="../resources/contenteditable-iframe-src.html" ></iframe>2 <iframe name="iframe" src="../resources/contenteditable-iframe-src.html" onload="runTest()"></iframe> 8 3 <ul id="console"></ul> 9 4 … … 18 13 19 14 function part1() { 20 21 // Hack to focus the frame, should be able to do frames['iframe'].focus() 22 eventSender.mouseMoveTo(50, 50); 23 eventSender.mouseDown(); 24 eventSender.mouseUp(); 15 frames['iframe'].document.body.focus(); 25 16 26 17 // Hack to perform the editing command. Should be able to 27 18 // call execCommand on the main document. 28 19 frames['iframe'].document.execCommand('InsertText', false, 'c'); 29 20 21 if (frames['iframe'].document.body.innerText != 'c') { 22 log("FAIL: could not insert text."); 23 if (window.layoutTestController) 24 layoutTestController.notifyDone(); 25 return; 26 } 27 28 if (!document.queryCommandEnabled('Undo')) { 29 log("FAIL: Undo is not enabled after text insertion."); 30 if (window.layoutTestController) 31 layoutTestController.notifyDone(); 32 return; 33 } 34 30 35 window.location = window.location.toString() + "?part2"; 31 36 } 32 37 33 38 function part2() { 39 if (frames['iframe'].document.body.innerText != '') 40 log("FAIL: subframe still has old content after navigaiton."); 41 34 42 if (!document.queryCommandEnabled('Undo')) 35 43 log("Success"); 36 44 else 37 log("Failure, Undo was still enabled after the location changed .");45 log("Failure, Undo was still enabled after the location changed (but at least we didn't crash!)"); 38 46 39 window.layoutTestController.notifyDone(); 47 if (window.layoutTestController) 48 layoutTestController.notifyDone(); 40 49 } 41 50 42 51 function runTest() { 43 if (!window.layoutTestController)44 return;45 46 52 if (window.location.toString().indexOf("?part2") == -1) { 47 window.layoutTestController.waitUntilDone(); 48 window.layoutTestController.dumpAsText(); 49 // Give the iframe a moment to come into being. 50 window.setTimeout(part1, 100); 53 part1(); 51 54 } else { 52 55 part2(); 53 56 } 54 55 57 } 56 58 57 runTest(); 59 if (window.layoutTestController) { 60 layoutTestController.waitUntilDone(); 61 layoutTestController.dumpAsText(); 62 } 58 63 59 64 </script> -
trunk/WebCore/ChangeLog
r37037 r37038 1 2008-09-28 Alexey Proskuryakov <ap@webkit.org> 2 3 Reviewed by Eric Seidel. 4 5 https://bugs.webkit.org/show_bug.cgi?id=20366 6 Reproducible test failure for editing/undo/undo-iframe-location-change.html 7 8 * ChangeLog-2006-05-10: Added bug URLs for a fix that included this test. 9 1 10 2008-09-28 Darin Adler <darin@apple.com> 2 11 -
trunk/WebCore/ChangeLog-2006-05-10
r24788 r37038 16750 16750 Reviewed by mjs 16751 16751 16752 <http://tinymce.moxiecode.com/example_full.php?example=true>16753 TinyMCE: Undo still enabled after a location change, crashes if performed16752 https://bugs.webkit.org/show_bug.cgi?id=7150 16753 <rdar://4433765> TinyMCE: Undo still enabled after a location change, crashes if performed 16754 16754 16755 16755 Can't clear undo/redo operations registered by subframes in didOpenURL,
Note: See TracChangeset
for help on using the changeset viewer.