Changeset 37676 in webkit

Timestamp:

Oct 18, 2008 12:06:17 AM (16 years ago)

Author:

jmalonzo@webkit.org

Message:

2008-10-17 Luke Kenneth Casson Leighton <​lkcl@lkcl.net>

Reviewed by Mark Rowe. Landed by Jan Alonzo.

​https://bugs.webkit.org/show_bug.cgi?id=20403
[Gtk] Segfault after a table with an iframe is attempted to be added twice to DOM model with javascript

• WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::frameLoaderDestroyed): (WebKit::FrameLoaderClient::detachedFromParent4):

Location:

trunk/WebKit/gtk

Files:

• ChangeLog (modified) (1 diff)
• WebCoreSupport/FrameLoaderClientGtk.cpp (modified) (2 diffs)

trunk/WebKit/gtk/ChangeLog

@@ +1 @@
+2008-10-17  Luke Kenneth Casson Leighton  <lkcl@lkcl.net>
+
+        Reviewed by Mark Rowe. Landed by Jan Alonzo.
+
+        https://bugs.webkit.org/show_bug.cgi?id=20403
+        [Gtk] Segfault after a table with an iframe is attempted to be added twice to DOM model with javascript
+
+        * WebCoreSupport/FrameLoaderClientGtk.cpp:
+        (WebKit::FrameLoaderClient::frameLoaderDestroyed):
+        (WebKit::FrameLoaderClient::detachedFromParent4):
+
 2008-10-06  David Hyatt  <hyatt@apple.com>
 

trunk/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp

@@ -232 +232 @@
 void FrameLoaderClient::frameLoaderDestroyed()
 {
+    g_object_unref(m_frame);
     m_frame = 0;
     delete this;
@@ -466 +467 @@
 void FrameLoaderClient::detachedFromParent4()
 {
-    ASSERT(m_frame);
-    g_object_unref(m_frame);
-    m_frame = 0;
 }